New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#443] Fix Tiled tilesets with margin/spacing defined #444

Merged

eonarheim merged 2 commits into main from bugfix/margin

Jun 29, 2023

Member

eonarheim commented Jun 28, 2023 •

edited

Loading

Closes #443

TODO:

Tests

Tiled and Excalibur use the same words for different things 🤦

Tiled tileset margin is the same as Excalibur's SpriteSheet.originOffset
Tiled tileset spacing is the same as Excalibur's SpriteSheet.margin

Uploaded a Tiled example that demonstrates this in the plugin

eonarheim added 2 commits

June 28, 2023 08:05


          fix: [#443] Fix Tiled tilesets with margin/spacing defined

9f7053a


          Add integration test

9be885b

eonarheim merged commit 0fe3031 into main

1 check passed

eonarheim deleted the bugfix/margin branch

June 29, 2023 13:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet