-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.17 #26
Conversation
09d6b74
to
c2b4622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that it took me so long to start reviewing this. Here my initial findings:
- This repo includes dependencies. Please run go mod vendor and go mod tidy (with go 1.17) to adjust the go.mod and go.sum file to the 1.17 version. (Without that, it gives me an error
go: vendored module github.com/davecgh/go-spew@v1.1.1 should be required explicitly in go.mod
) - Would be great if you could also add the vendor folder to the gitignore file, it is currently missing there.
- Did you get the tests to pass? If yes, how? They fail for me. However this seems unrelated to the Go version update.
(I might add more comments later if anything else comes up.)
Thanks for taking a look at this. I'll go over this in more detail over the weekend and will keep you posted. |
c2b4622
to
16bf47c
Compare
@junedev Ran I ran the tests with |
Thanks for the update and checking regarding the failing test. Feel free to merge this but please create an issue for the failing test cases if there isn't already one. |
Issue for the failing tests: #29 |
Part of exercism/go#1881
Related PR's: