Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non llm based metrics #1268

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: non llm based metrics #1268

merged 3 commits into from
Sep 11, 2024

Conversation

shahules786
Copy link
Member

@shahules786 shahules786 commented Sep 10, 2024 •
edited
Loading

  1. rename metrics
  2. delay import of optional dependencies

@shahules786 shahules786 marked this pull request as ready for review September 10, 2024 18:40
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@shahules786 shahules786 changed the title fix: make dependecies optional fix: rename non llm based metrics Sep 11, 2024
@shahules786 shahules786 changed the title fix: rename non llm based metrics fix: non llm based metrics Sep 11, 2024
@shahules786 shahules786 merged commit 3076f50 into explodinggradients:main Sep 11, 2024
15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shahules786