Add option to disable progress bar in evaluate
#1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello there 👋 I noticed that there was no way to disable the progress bar and thought it'd nice to have the option to silence the `tqdm` call in the executor. I've added the following changes: Add `show_progress` flag to `Executor` class and update `evaluate` function to use it. * **Executor Class Changes:** - Add `show_progress` flag to the `Executor` class in `src/ragas/executor.py`. - Use the `show_progress` flag to control the display of the progress bar. - If `show_progress` is set to False, disable `tqdm` usage for displaying progress bars. * **Evaluate Function Changes:** - Add `show_progress` parameter to the `evaluate` function in `src/ragas/evaluation.py`. - Pass the `show_progress` flag to the `Executor` class during initialization in the `evaluate` function.
dosubot
bot
added
the
size:XS
freddiev4
changed the title
show_progress flag to Executor classevaluate
jjmachan
approved these changes
Sep 12, 2024
shahules786
pushed a commit
to shahules786/ragas
that referenced
this pull request
Sep 12, 2024
…1279) Hello there 👋 I noticed that there was no way to disable the progress bar and thought it'd nice to have the option to silence the `tqdm` call in the executor, as it doesn’t play nicely with logs and adds noise. I've added the following changes: Add `show_progress` flag to `Executor` class and update `evaluate` function to use it. * **Executor Class Changes:** - Add `show_progress` flag to the `Executor` class in `src/ragas/executor.py`. - Use the `show_progress` flag to control the display of the progress bar. - If `show_progress` is set to False, disable `tqdm` usage for displaying progress bars. * **Evaluate Function Changes:** - Add `show_progress` parameter to the `evaluate` function in `src/ragas/evaluation.py`. - Pass the `show_progress` flag to the `Executor` class during initialization in the `evaluate` function.
shahules786
pushed a commit
to shahules786/ragas
that referenced
this pull request
Sep 12, 2024
…1279) Hello there 👋 I noticed that there was no way to disable the progress bar and thought it'd nice to have the option to silence the `tqdm` call in the executor, as it doesn’t play nicely with logs and adds noise. I've added the following changes: Add `show_progress` flag to `Executor` class and update `evaluate` function to use it. * **Executor Class Changes:** - Add `show_progress` flag to the `Executor` class in `src/ragas/executor.py`. - Use the `show_progress` flag to control the display of the progress bar. - If `show_progress` is set to False, disable `tqdm` usage for displaying progress bars. * **Evaluate Function Changes:** - Add `show_progress` parameter to the `evaluate` function in `src/ragas/evaluation.py`. - Pass the `show_progress` flag to the `Executor` class during initialization in the `evaluate` function.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there 👋 I noticed that there was no way to disable the progress bar and thought it'd nice to have the option to silence the
tqdmcall in the executor, as it doesn’t play nicely with logs and adds noise.I've added the following changes:
Add
show_progressflag toExecutorclass and updateevaluatefunction to use it.Executor Class Changes:
show_progressflag to theExecutorclass insrc/ragas/executor.py.show_progressflag to control the display of the progress bar.show_progressis set to False, disabletqdmusage for displaying progress bars.Evaluate Function Changes:
show_progressparameter to theevaluatefunction insrc/ragas/evaluation.py.show_progressflag to theExecutorclass during initialization in theevaluatefunction.