Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-picker] Fix incorrect asset type for videos on iOS #19932

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Nov 8, 2022

Why

#19570 introduced a regression that causes all videos to have the default type (image).
Fixes #19883

How

  • Set type to video for video assets
  • Ensured that all tests are passing (some were broken, not sure why that passed QA before the SDK release?)

Test Plan

Tested with test-suite and NCL

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 8, 2022
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 8, 2022
@tsapeta tsapeta marked this pull request as ready for review November 8, 2022 14:08
@tsapeta tsapeta merged commit eebaafa into main Nov 8, 2022
@tsapeta tsapeta deleted the @tsapeta/ios/fix-image-picker-asset-type branch November 8, 2022 15:18
@tsapeta tsapeta added the published Changes from the PR have been published to npm label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS Picker results in type 'image' for both videos and photos
3 participants