Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][expo-device] migrate to new modules API #20118

Merged

Conversation

alanjhughes
Copy link
Collaborator

Why

Migrate module to use new modules API

How

Followed the usual steps involved in migrating a module

Test Plan

Tested using the bare expo app. Continues to work as before.

@alanjhughes alanjhughes changed the title @alanhughes/android/modules expo device [android][expo-device] migrate to new modules API Nov 18, 2022
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 18, 2022
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 18, 2022
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for your contribution 🥇

@lukmccall lukmccall merged commit 5d331de into expo:main Nov 23, 2022
@alanjhughes alanjhughes deleted the @alanhughes/android/modules-expo-device branch December 1, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants