[router]: Fix fast refresh on layout files #29977
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix Fast Refresh on
_layout
files that exportunstable_settings
and/orErrorBoundary
.How
Metro's FastRefresh implementation has a set of rule that Expo Router does not follow causing full app reloads.
Next.js is a similar framework to Expo Router which has resolved the issue in a similar fashion. In the Next.js implementation they
getStaticProps
/getStaticPaths
are bundled into a__N_SSG
export`ReactRefresh
with their own extended versionWhile the Next.js solution is more robust, I believe this solution is simple enough for our current needs.
Possible additional changes:
ErrorBoundary
and thectx
export with a Symbol and use that forisLikelyComponentType
detectionunstable_settings
only exists on a module with a default exportunstable_settings
duringgetRoutes
with a Symbol and use that forisLikelyComponentType
detectionTest Plan
npx create-expo-app app
_layout
fileChecklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).