Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore IncrementResponse type #397

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix: restore IncrementResponse type #397

merged 2 commits into from
Sep 12, 2023

Conversation

nfriedly
Copy link
Member

Restores IncrementResponse as an alias of ClientRateLimitInfo

fixes express-rate-limit/rate-limit-redis#192 (hopefully)

@nfriedly
Copy link
Member Author

@shenie would you mind trying this out and confirm that it fixes the typing error?

I think the commands are going to be something along these lines:

cd ~
git clone https://github.com/express-rate-limit/express-rate-limit.git
cd express-rate-limit
git checkout fix-type
npm install
npm run compile
npm link
cd <directory where your project is>
npm link express-rate-limit

(The npm link command lets you use a local version of a dependency instead of the one installed from npm - see https://docs.npmjs.com/cli/v9/commands/npm-link for more.)

Once you're done testing the fix, I believe a regular npm install express-rate-limit will undo the link.

@nfriedly
Copy link
Member Author

I'd also like to figure out why our integration test didn't catch this...

@shenie
Copy link

shenie commented Sep 12, 2023

@shenie would you mind trying this out and confirm that it fixes the typing error?

done. it worked

@nfriedly
Copy link
Member Author

done. it worked

awesome; I'll go ahead and ship this now and look into the tests later

@nfriedly nfriedly merged commit 82a1d46 into main Sep 12, 2023
32 checks passed
@nfriedly nfriedly deleted the fix-type branch September 12, 2023 02:02
@nfriedly
Copy link
Member Author

Ok, 6.11.2 is now live on npm with the fix.

Thanks for bring it to our attention and helping me test it!

@gamemaker1
Copy link
Member

Thanks for fixing this so quickly @nfriedly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants