Add express to badgeboard #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dougwilson |
|
Oops, sorry I missed this. Yea, express wqs originally left out on purpose, in order for the board to just list the middleware. I wonder if we can add like a feature to badgeboard to support like grouping instead of just discarding certain projects from the board. |
|
Grouping could be nice. But it's a new feature that could be added after this PR lands in my opinion. |
|
Not really, because ad I said, it was specifically excluded because we didn't want to mix it in with the other middleware. If it was accidentally left our, sure, but it's not missing on accident. |
|
I will work on adding the feature to badgeboard as soon as I am able and then get this landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like adding express to the badgeboard could solve this issue: expressjs/express#3710