Skip to content

Commit

Permalink
emit rustc-check-cfg info and fix doc_lazy_continuation clippy warning
Browse files Browse the repository at this point in the history
  • Loading branch information
yaahc committed Aug 29, 2024
1 parent fc83cb8 commit c17ab5c
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 8 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/target
**/*.rs.bk
tags
tags.temp
tags.lock
3 changes: 3 additions & 0 deletions color-spantrace/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ enum Toolchain {

impl Toolchain {
fn set_feature(self) {
println!("cargo:rustc-check-cfg=cfg(nightly)");
println!("cargo:rustc-check-cfg=cfg(beta)");
println!("cargo:rustc-check-cfg=cfg(stable)");
match self {
Toolchain::Nightly => println!("cargo:rustc-cfg=nightly"),
Toolchain::Beta => println!("cargo:rustc-cfg=beta"),
Expand Down
7 changes: 7 additions & 0 deletions eyre/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ use std::{
};

fn main() {
println!("cargo:rustc-check-cfg=cfg(nightly)");
println!("cargo:rustc-check-cfg=cfg(track_caller)");
println!("cargo:rustc-check-cfg=cfg(generic_member_access)");
println!("cargo:rustc-check-cfg=cfg(eyre_no_fmt_args_capture)");
println!("cargo:rustc-check-cfg=cfg(backtrace)");
println!("cargo:rustc-check-cfg=cfg(eyre_no_fmt_arguments_as_str)");
println!("cargo:rustc-check-cfg=cfg(doc_cfg)");
let ac = autocfg::new();

// https://github.com/rust-lang/rust/issues/99301 [nightly]
Expand Down
16 changes: 8 additions & 8 deletions eyre/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@
//! to avoid using `eyre::Report` as your public error type.
//!
//! - You export an undocumented error interface that is otherwise still
//! accessible via downcast, making it hard for users to react to specific
//! errors while not preventing them from depending on details you didn't mean
//! to make part of your public API.
//! accessible via downcast, making it hard for users to react to specific
//! errors while not preventing them from depending on details you didn't mean
//! to make part of your public API.
//! - This in turn makes the error types of all libraries you use a part of
//! your public API as well, and makes changing any of those libraries into
//! undetectable runtime breakage.
//! your public API as well, and makes changing any of those libraries into
//! undetectable runtime breakage.
//! - If many of your errors are constructed from strings, you encourage your
//! users to use string comparison for reacting to specific errors, which is
//! brittle and turns updating error messages into potentially undetectable
//! runtime breakage.
//! users to use string comparison for reacting to specific errors, which is
//! brittle and turns updating error messages into potentially undetectable
//! runtime breakage.
//!
//! ## Details
//!
Expand Down

0 comments on commit c17ab5c

Please sign in to comment.