Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exa PR) 1119 #36

Closed
wants to merge 2 commits into from
Closed

(exa PR) 1119 #36

wants to merge 2 commits into from

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

github.com/ogham/exa/pulls/1119

Trash  # ~/.local/share/Trash
*.a  # ~/.pyenv/versions/3.9.13/lib/libpython3.9.a
*.mdb  # https://github.com/NVIDIA/DALI_extra/tree/main/db/lmdb
xinitrc  # /etc/X11/xinit/xinitrc
xserverrc  # /etc/X11/xinit/xserverrc
*.bash_logout  # /etc/bash.bash_logout
.xinitrc  # ~/.xinitrc
.xprofile  # ~/.xprofile
.pam_environment  # ~/.pam_environment
requirements.txt  # python config file
Copy link
Member Author

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about these

m.insert(".zshrc", '\u{f489}'); // 
m.insert("Cargo.lock", '\u{e7a8}'); //
m.insert("AUTHORS", '\u{f718}'); //
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbol doesn't render for me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should render on the nerdfonts site: https://www.nerdfonts.com/cheat-sheet

I found it under 'document'
New name seems to be 'nf-md-file_document' (will be fixed with #9)

Comment on lines +65 to +66
m.insert(".xinitrc", '\u{f489}'); // 
m.insert(".xprofile", '\u{f489}'); // 
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about these

m.insert("bin", '\u{e5fc}'); // 
m.insert("Cargo.lock", '\u{e7a8}'); // 
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be already present on main (at least it shows that icon when I run with --icons)

@@ -81,12 +85,17 @@ lazy_static! {
m.insert("hidden", '\u{f023}'); // 
m.insert("include", '\u{e5fc}'); // 
m.insert("lib", '\u{f121}'); // 
m.insert("LICENSE", '\u{f718}'); // 
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbol doesn't render for me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same document icon 'nf-md-file_document'

@@ -108,6 +117,7 @@ pub fn icon_for_file(file: &File<'_>) -> char {
else if let Some(icon) = extensions.icon_file(file) { icon }
else if let Some(ext) = file.ext.as_ref() {
match ext.as_str() {
"a" => '\u{f17c}', // 
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure what this even is

@@ -118,6 +128,7 @@ pub fn icon_for_file(file: &File<'_>) -> char {
"awk" => '\u{f489}', // 
"bash" => '\u{f489}', // 
"bash_history" => '\u{f489}', // 
"bash_logout" => '\u{f489}', // 
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is optimal

@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@sbatial
Copy link
Collaborator

sbatial commented Jul 30, 2023

I think it would make sense to maybe close this one and apply the proposed changes after #9
Because as far as I can tell #9 is as good as ready now.

I would then go forward with reviewing it

@cafkafk cafkafk closed this Jul 30, 2023
@cafkafk cafkafk deleted the pr-1119 branch July 30, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants