Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(exa PR) 1094 #40

Merged
merged 3 commits into from
Jul 30, 2023
Merged

(exa PR) 1094 #40

merged 3 commits into from
Jul 30, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

github.com/ogham/exa/pulls/1094

sbatial
sbatial approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@sbatial sbatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: needs to be fixed to work with newer nerdfonts I think (but that's what #9 is for)

@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

note: needs to be fixed to work with newer nerdfonts I think (but that's what #9 is for)

I'll make it a draft until that's done.

@cafkafk cafkafk marked this pull request as draft July 30, 2023 03:21
@sbatial
Copy link
Collaborator

sbatial commented Jul 30, 2023

Ah no. I formulated it wrong.
It'll can be merged for now and then changed in bulk with all the others in #9

@sbatial sbatial marked this pull request as ready for review July 30, 2023 11:50
@sbatial sbatial merged commit bd699bd into main Jul 30, 2023
@sbatial sbatial deleted the pr-1094 branch July 30, 2023 11:50
@sbatial sbatial mentioned this pull request Jul 30, 2023
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatial sbatial sbatial approved these changes

Assignees
No one assigned
Labels
features › icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cafkafk @sbatial @mihaigalos