Improve code quality

Remove code flaws detected by PMD. PMD Rules: * NP_LOAD_OF_KNOWN_NULL_VALUE * DCN_NULLPOINTER_EXCEPTION
f4b6a3 · Jul 7, 2024 · 39575d5 · 39575d5
1 parent 84fd314
commit 39575d5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/github/f4b6a3/uuid/codec/StandardStringCodec.java b/src/main/java/com/github/f4b6a3/uuid/codec/StandardStringCodec.java
@@ -167,7 +167,7 @@ public String encode(UUID uuid) {
 	public UUID decode(final String string) {
 
 		if (string == null) {
-			throw InvalidUuidException.newInstance(string);
+			throw InvalidUuidException.newInstance(null);
 		}
 
 		final String modified = modify(string);

diff --git a/src/main/java/com/github/f4b6a3/uuid/util/UuidValidator.java b/src/main/java/com/github/f4b6a3/uuid/util/UuidValidator.java
@@ -146,7 +146,7 @@ public static boolean isValid(final char[] uuid, int version) {
 	 */
 	public static void validate(final UUID uuid) {
 		if (uuid == null) {
-			throw InvalidUuidException.newInstance(uuid);
+			throw InvalidUuidException.newInstance(null);
 		}
 	}
 

diff --git a/src/main/java/com/github/f4b6a3/uuid/util/internal/NetworkUtil.java b/src/main/java/com/github/f4b6a3/uuid/util/internal/NetworkUtil.java
@@ -103,7 +103,7 @@ public static synchronized String mac(NetworkInterface nic) {
 		}
 
 		try {
-			if (nic != null) {
+			if (nic != null && nic.getHardwareAddress() != null) {
 				byte[] ha = nic.getHardwareAddress();
 				String[] hex = new String[ha.length];
 				for (int i = 0; i < ha.length; i++) {
@@ -112,7 +112,7 @@ public static synchronized String mac(NetworkInterface nic) {
 				mac = String.join("-", hex);
 				return mac;
 			}
-		} catch (SocketException | NullPointerException e) {
+		} catch (SocketException e) {
 			return null;
 		}