Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Quality #101

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Improve Code Quality #101

merged 4 commits into from
Mar 31, 2024

Conversation

pateljay15
Copy link

Improved Code Quality by removing Design code smells and Implementation code smells. Code is working fine after Refactoring and all Tests Cases are passed. Moreover, I have added 5 additional Unit Test Cases for MachineId Class.

@pateljay15
Copy link
Author

After reviewing the pull request, you think the changes I have made are acceptable to be merged into this Open Source Repository. Then it will be helpful for me if you accept the pull request before 31st 11:59 PM.

@fabiolimace
Copy link
Member

Hi, @pateljay15

Your work really improved readability and removed some of the project's smells. Thank you very much. However, I had already approved the changes when this build problem occurred. I think that the code will be ready for merge after this.

2024-03-31T12:59:40.1910969Z ##[group]Run mvn -B -q -ff -ntp package --file pom.xml
mvn -B -q -ff -ntp package --file pom.xml
shell: /usr/bin/bash -e {0}
env:
  JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.402-6/x64
  JAVA_HOME_8_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.402-6/x64
 [ERROR] Some problems were encountered while processing the POMs:
[FATAL] 'dependencies.dependency[com.github.f4b6a3:uuid-creator:5.3.8-SNAPSHOT]' for com.github.f4b6a3:uuid-creator:5.3.8-SNAPSHOT is referencing itself. @ line 41, column 15
 @ 
 The build could not read 1 project -> [Help 1]
   
   The project com.github.f4b6a3:uuid-creator:5.3.8-SNAPSHOT (/home/runner/work/uuid-creator/uuid-creator/pom.xml) has 1 error
     'dependencies.dependency[com.github.f4b6a3:uuid-creator:5.3.8-SNAPSHOT]' for com.github.f4b6a3:uuid-creator:5.3.8-SNAPSHOT is referencing itself. @ line 41, column 15
 
 To see the full stack trace of the errors, re-run Maven with the -e switch.
 Re-run Maven using the -X switch to enable full debug logging.
 
 For more information about the errors and possible solutions, please read the following articles:
 [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Process completed with exit code 1.

@pateljay15
Copy link
Author

hey @fabiolimace, thanks for your time for letting me know the issue. Solved that problem, see if its possible for you to review and accept the pull request.

@fabiolimace fabiolimace merged commit e30f093 into f4b6a3:master Mar 31, 2024
9 checks passed
@fabiolimace
Copy link
Member

Great job! Thanks @pateljay15 !

@pateljay15
Copy link
Author

Thanks a lot !! @fabiolimace for accepting my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants