Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version #102

Merged
merged 42 commits into from
Jul 7, 2024
Merged

Next version #102

merged 42 commits into from
Jul 7, 2024

Conversation

fabiolimace
Copy link
Member

Preparing the next version.

Add a fast (i.e. non-cryptographic) version of UUID v7.
GUID must be independent of the rest of the library. Additionally,
Parser code is only used by GUID.

Although some consider nested classes to be a smell, this is not true in
all cases. If you think that's the case, I hope you can forgive this
one.
Static mocking is not working.
Add tests for static methods in MachineId.java.
The JVM unique number tries to mitigate the fact that the thread
local random is not seeded with a secure random seed by default.
Their seeds are based on temporal data and predefined constants.
Although the seeds are unique per JVM, they are not across JVMs.
It helps to generate different sequences of numbers even if two
ThreadLocalRandom are by chance instantiated with the same seed.
Of course it doesn't better the output, but doesn't hurt either.
Remove `Builder.withRandomFunction(IntFunction<byte[]>`.

There are too many "with" options already.
Using SplittableRandom with a seed for reproducibility.
Changes:

* BinaryCodec -> StandardBinaryCodec
* StringCodec -> StandardStringCodec
Renamed:

* UuidUtil.isRfc4122() -> UuidUtil.isStandard()
* UuidVariant.VARIANT_RFC4122 -> UuidVariant.VARIANT_STANDARD
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, github/codeql-action/upload-sarif@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, github/codeql-action/upload-sarif@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, github/codeql-action/upload-sarif@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, github/codeql-action/upload-sarif@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Copy link
Member Author

@fabiolimace fabiolimace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@fabiolimace fabiolimace merged commit d68abc9 into master Jul 7, 2024
9 checks passed
@fabiolimace fabiolimace deleted the next_version branch July 7, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant