This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Ability to specify a build target for kotlin_home #2121
Comments
|
cc @kageiit, @cwoodwar6, @thalescm |
This was referenced Dec 2, 2018
|
👍 I agree with the suggested changes. |
raviagarwal7
added a commit
to raviagarwal7/buck
that referenced
this issue
Dec 13, 2018
- Support specifying a source path for kotlin_home buck config - Simplified and cleaned up logic to look up kotlin home. - Updated Docs Resolves facebook#2121 Dependent PR’s: facebook#2131 facebook#2130
raviagarwal7
added a commit
to raviagarwal7/buck
that referenced
this issue
Dec 20, 2018
- Support specifying a source path for kotlin_home buck config - Simplified and cleaned up logic to look up kotlin home. - Updated Docs Resolves facebook#2121 Dependent PR’s: facebook#2131 facebook#2130
raviagarwal7
added a commit
to raviagarwal7/buck
that referenced
this issue
Dec 21, 2018
- Support specifying a source path for kotlin_home buck config - Simplified and cleaned up logic to look up kotlin home. - Updated Docs Resolves facebook#2121 Dependent PR’s: facebook#2131 facebook#2130
raviagarwal7
added a commit
to raviagarwal7/buck
that referenced
this issue
Dec 21, 2018
- Support specifying a source path for kotlin_home buck config - Simplified and cleaned up logic to look up kotlin home. - Updated Docs Resolves facebook#2121 Dependent PR’s: facebook#2131 facebook#2130
thalescm
pushed a commit
to thalescm/buck
that referenced
this issue
Jan 14, 2019
…k#2122) Summary: - Support specifying a source path for `kotlin_home` buck config - Simplified and cleaned up logic to look up kotlin home. - Updated Docs Resolves facebook#2121 Dependent PR’s: facebook#2131 facebook#2130 Pull Request resolved: facebook#2122 Reviewed By: styurin Pulled By: styurin fbshipit-source-id: df2f2524bd
|
could we please re-open it since the PR was reverted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently kotlin compilation can happen using the external kotlinc tool or in memory using the
kotlin_homebuck config.The current implementation assumes that the
kotlin_homewill always be a path in the filesystem.Proposal is to remove that assumption and make
kotlin_homesupport a source path. The changes would mostly be toJarBackedReflectedKotlinc.ExternalKotlincwill not change much.Also planning to remove all the complex lookups for magically finding kotin libraries. looking at the current kotlin installation in mac (version
1.2.71) all kotlin libraries can be found inKOTLIN_HOME/libexec/liband all the executables can be found inKOTLIN_HOME/bin. So, we can just only lookup inlibexec/libsubfolder and remove all other custom logic.we also have corresponding pull request in okbuck to move to using source paths - uber/okbuck#748
The text was updated successfully, but these errors were encountered: