add two commands pclassmethod and pinstancemethod #113

longv2go · 2015-09-17T06:31:08Z

This command show the class`s methods in a pretty way.

Options:
--address/-a ; Print the implementation address of the method
--instance/-i ; Print the instance methods
--class/-c ; Print the class methods

You can get the runtime address of the method use option '-a' then do something more with that address,
such as run lldb command "dis -a " to disassemble the method.

Examples:

(lldb) pme -a self
Class Methods:
No instance methods were found.

Instance Methods:
- (void)outAction:(id)arg0  0x000ee680
- (void)innerAction:(id)arg0  0x000ee6f0
- (void)inges:(id)arg0  0x000ee760
- (void)underGes:(id)arg0  0x000ee7d0
......

Merge

Merge master

merge from souce

marge

Merge

kastiglione · 2015-09-28T16:45:10Z

Thanks for the pull request!

Why not one command (say pmethods) and let the person pass either a class or an instance?

(lldb) pmethods self
- (void)setSignInButton:(id)arg0 
- (id)signInFailureText
- (void)setSignInFailureText:(id)arg0 
- (void).cxx_destruct
......
(lldb) pmethods [self class]
+ (id)test:(id)arg0

longv2go · 2015-09-29T06:05:14Z

@kastiglione Now It supply only one command 'pmethods', it take two options, if '-a' set, it would print all class methods and instance mehtods, if '-c' set, it would only print class methods, default it only print intance methods.

kastiglione · 2015-09-29T06:18:26Z

👍 I will take a look tomorrow (it's the end of the night for me now)

One question: What happens if you call pmethods XYSomeClass?

longv2go · 2015-09-29T07:27:16Z

@kastiglione The pmethods can take an Instance of some Class or a Class object as its argument, and It
would print the same thing. I know the argument is an Instance or just a Class object. It use the options '-a' '-c' to determine print the class methods or instance methods.

(lldb) pme self
- (id)signInService
- (id)usernameTextField
- (bool)isValidUsername:(id)arg0 
......

(lldb) pme [self class]
- (id)signInService
- (id)usernameTextField
- (bool)isValidUsername:(id)arg0 
......

(lldb) pme -a self
+ (id)test:(id)arg0 
- (id)signInService
- (id)usernameTextField
- (bool)isValidUsername:(id)arg0 
- (bool)isValidPassword:(id)arg0 
- (id)signInSignal
......

kastiglione · 2015-10-14T17:10:48Z

thanks, will try this out today or tomorrow!

PaulTaykalo · 2015-12-11T06:49:07Z

Is there any way to know, what prevents this PR to be merged in ?:)

fbdeveloper · 2015-12-13T07:03:24Z

commands/FBClassDump.py

+    return 'pmethods'
+
+  def description(self):
+    return 'Print the class instance methods.'


"Print the class and instance methods of a class."

@longv2go Do you plan to update this description?

kastiglione · 2015-12-13T07:06:30Z

@PaulTaykalo I dropped the ball on following up on the review, apologies.

fbdeveloper · 2015-12-13T07:07:04Z

commands/FBClassDump.py

+
+  def options(self):
+    return [
+      fb.FBCommandArgument(short='-a', long='--all', arg='all', help='If display all methos include class and instance methods', default=False, boolean=True),


I find the combination of '-a' and '-c' to be a bit counter-intuitive. What about '-i/--instance' for instance and '-c/--class' for class and if neither is specified then it defaults to both. This ensures that there aren't any combinations that don't make sense.

I just add a new '-a' option to show the implementation address of the method

longv2go · 2015-12-16T03:53:43Z

Hi, @fbdeveloper @kastiglione @PaulTaykalo , I change the implementation of pmethods, the CLI not changed. The last version has some issues, it run slowly when the class has many methods and it`s implementation is not so clearly. So I wrote a new method 'evaluate' in fblldbbase.py, it can evaluate a batch of Objective-C expressions and automatic transform the Objective-C object to Python object. I rewrote pmethods base on 'evaluate'. The lines of code go to down, run faster, and more clearly now. Please review this. :)

arigrant · 2015-12-16T04:39:40Z

Ah sorry, that was me, accidentally logged into an old fb dev account for a repo I was looking into.

jamesgpearce · 2015-12-16T04:44:15Z

hahaha

PaulTaykalo · 2015-12-16T05:50:39Z

commands/FBClassDump.py

+  def __init__(self, json):
+    self.name = json['name']
+    self.type_encoding = json['type_encoding']
+    self.peremeters_type = json['parameters_type']


parameters_type

longv2go · 2015-12-16T06:44:30Z

Thanks for reviewing! Sorry for my poor english!

kastiglione · 2015-12-18T07:30:47Z

@arigrant I'll be traveling for the next few days. Would you mind merging this when ready?

Thanks @longv2go!

kastiglione · 2015-12-18T07:32:51Z

fblldbobjcruntimehelpers.py

@@ -32,6 +32,10 @@ def class_getSuperclass(klass):
  value = fb.evaluateExpression(command)
  return value

+def class_isMetaClass(klass):
+    command = '(BOOL)class_isMetaClass((Class){})'.format(klass)
+    return fb.evaluateBooleanExpression(command)


@longv2go You don't need the (BOOL) cast when calling evaluateBooleanExpression.

kastiglione · 2016-01-01T19:52:01Z

Thanks @longv2go!

add two commands pclassmethod and pinstancemethod

longv2go and others added 12 commits January 29, 2015 01:43

Merge pull request #1 from facebook/master

52c8500

Merge

Merge pull request #2 from facebook/master

44477a9

Merge master

Merge pull request #3 from facebook/master

bfc1bcd

merge from souce

Merge pull request #4 from facebook/master

01cd621

marge

Merge pull request #5 from facebook/master

5e46ca7

Merge

add class dump

48beada

fix

d59b1d3

add pclassmethods command

c910d48

change error log

cab9666

handle error

37f5a96

change FBPrintClassInstanceMethods command name

34a5152

fix bug

c701083

facebook-github-bot added the CLA Signed label Sep 17, 2015

combine the pclassmethods and pinstancemehtods

57a4055

pmethods can take an instance para

df9db7c

fbdeveloper reviewed Dec 13, 2015
View reviewed changes

longv2go added 6 commits December 15, 2015 20:39

change the impletation of pmethods with json

b59e8fa

Merge remote-tracking branch 'facebook/master' into fb_classdump

f967b1d

rename the eval to evaluate and move it to fblldbbase

31b6e2d

fix typo mistake

c5b33d1

Merge remote-tracking branch 'facebook/master'

3b39c3c

Merge branch 'fb_classdump'

c4870d5

longv2go added 2 commits December 16, 2015 11:54

fix typo error

3299b90

Remove no need import

2fba2df

PaulTaykalo reviewed Dec 16, 2015
View reviewed changes

longv2go added 2 commits December 16, 2015 14:22

Fix typo in FBClassDump.py

695049b

Fix bug in check_expr

a0c0540

kastiglione reviewed Dec 18, 2015
View reviewed changes

longv2go added 3 commits December 18, 2015 16:45

Remove unnessary cast in class_isMetaClass

3154bb3

Fix typo on fblldbbase.py

c6eb2b2

Fix description of pmethods

4f2f0ec

kastiglione added a commit that referenced this pull request Jan 1, 2016

Merge pull request #113 from longv2go/master

867b4e2

add two commands pclassmethod and pinstancemethod

kastiglione merged commit 867b4e2 into facebook:master Jan 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add two commands pclassmethod and pinstancemethod #113

add two commands pclassmethod and pinstancemethod #113

longv2go commented Sep 17, 2015

kastiglione commented Sep 28, 2015

longv2go commented Sep 29, 2015

kastiglione commented Sep 29, 2015

longv2go commented Sep 29, 2015

kastiglione commented Oct 14, 2015

PaulTaykalo commented Dec 11, 2015

fbdeveloper Dec 13, 2015

kastiglione Dec 18, 2015

kastiglione commented Dec 13, 2015

fbdeveloper Dec 13, 2015

longv2go Dec 14, 2015

longv2go Dec 14, 2015

longv2go commented Dec 16, 2015

arigrant commented Dec 16, 2015

jamesgpearce commented Dec 16, 2015

PaulTaykalo Dec 16, 2015

longv2go commented Dec 16, 2015

kastiglione commented Dec 18, 2015

kastiglione Dec 18, 2015

kastiglione commented Jan 1, 2016

add two commands pclassmethod and pinstancemethod #113

add two commands pclassmethod and pinstancemethod #113

Conversation

longv2go commented Sep 17, 2015

kastiglione commented Sep 28, 2015

longv2go commented Sep 29, 2015

kastiglione commented Sep 29, 2015

longv2go commented Sep 29, 2015

kastiglione commented Oct 14, 2015

PaulTaykalo commented Dec 11, 2015

fbdeveloper Dec 13, 2015

Choose a reason for hiding this comment

kastiglione Dec 18, 2015

Choose a reason for hiding this comment

kastiglione commented Dec 13, 2015

fbdeveloper Dec 13, 2015

Choose a reason for hiding this comment

longv2go Dec 14, 2015

Choose a reason for hiding this comment

longv2go Dec 14, 2015

Choose a reason for hiding this comment

longv2go commented Dec 16, 2015

arigrant commented Dec 16, 2015

jamesgpearce commented Dec 16, 2015

PaulTaykalo Dec 16, 2015

Choose a reason for hiding this comment

longv2go commented Dec 16, 2015

kastiglione commented Dec 18, 2015

kastiglione Dec 18, 2015

Choose a reason for hiding this comment

kastiglione commented Jan 1, 2016