Adding text input command #137
Conversation
… command to be setxt
| self.findFirstResponder(subview, replacementText) | ||
| else: | ||
| if isFirstResponder(view): | ||
| setTextInView(view, replacementText) |
There was a problem hiding this comment.
My python is clearly lacking, how does this else: section work? Does it only run if the for loop has nothing to loop over (in this case view count is zero)?
There was a problem hiding this comment.
Yes that's exactly it. My python isn't that great either, only found out about this while writing this code.
There was a problem hiding this comment.
This won't handle any first responder that has subviews. Is there a reason for that? I'm not aware of anything that prevents a view with subviews from being first responder.
There was a problem hiding this comment.
This command is intended to be used after selecting a text field/text view, making it first responder, then setting the text on it.
With that in mind, if anything else is first responder at the time this command is run it will either do nothing, or set the text property on it.
I took the happy path for this, but I could put checks in the setTextInView function which only set text on classes which respond to setText:.
There was a problem hiding this comment.
Just looking back over the code, this branch of code is only executed when a view has no subviews.
There was a problem hiding this comment.
this branch of code is only executed when a view has no subviews.
Right, and I'm wondering about cases where some text input view has internal subviews. There's no guarantee that that a text input view will always have no subviews. I think the isFirstResponder check should go above the loop, and if it fails, then loop over subviews. This would make it breadth first, but I don't see a problem with that, do you?
There was a problem hiding this comment.
Nope, no issue. Pushed it up.
|
Thanks @tecknut for the pull request! |
|
I'm going to give this a day or two to see if @gkassabli has an feedback or thoughts about the accessibility part. |
|
Looks good to me |
|
Thanks! |
|
Thanks guys ! |
Additions
inputcommand which sets text on text views or text fields which were first responder when execution paused.setxtcommand which sets text on a view by accessibility ID.Example