Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'pbundlepath' Print application's bundle directory path #152

Merged
merged 1 commit into from
May 9, 2016

Conversation

Ashton-W
Copy link
Contributor

Very similar to the existing pdocspath, this new command pbundlepath prints the path to the app bundle. Basically just [[NSBundle mainBundle] bundlePath] but wrapped in a nice chisel command.

@ghost ghost added the CLA Signed label Apr 28, 2016
@kastiglione
Copy link
Contributor

kastiglione commented May 3, 2016

Thanks. I feel like it would be good to have just one command for "all" things path related. For example:

Print docs path:
ppath -d

Print bundle path:
ppath -b

or, something like that.

Although I said "all", for now we can handle just these two paths, and add any other paths later. By default, ppath could print both the doc and bundle path, but wouldn't put anything in the pasteboard I guess? People can easily create their own pdocspath or pbundlepath aliases in their .lldbinit.

Thoughts?

@Ashton-W
Copy link
Contributor Author

Ashton-W commented May 3, 2016

I originally wrote and shared this as a simple alias for use in an .lldbinit file and it was suggested to add t to chisel.

I can't think of any others paths that aren't closely relative to either of these two directories - so I don't see anyone having a good case for adding more ppath type commands.

What do you think?

@Ashton-W
Copy link
Contributor Author

Ashton-W commented May 3, 2016

I do like the idea of having options for these commands as shortcuts to particular directories of interest eg: Caches

@Ashton-W
Copy link
Contributor Author

Ashton-W commented May 3, 2016

Ha, in saying that I do see how two commands for the different sets of interesting app directories could be confusing - even if they are grouped by which path they are relative to. :)

(Sorry no edit on mobile github)

@kastiglione
Copy link
Contributor

it sounds like you're agreeing with the idea of one unified command, but I'm not 100% sure I'm interpreting your comments correctly…

@Ashton-W
Copy link
Contributor Author

Ashton-W commented May 5, 2016

I'll try creating a unified command. Did you want to accept this PR as-is?

@kastiglione
Copy link
Contributor

kastiglione commented May 5, 2016

Ideally we wouldn't introduce a command only to remove it shortly thereafter. If the unified command isn't going to happen any time soon, then yep I'll merge this. If you're aiming to soon work on the unified command, then I would hold off on this pull request.

@Ashton-W
Copy link
Contributor Author

Ashton-W commented May 5, 2016

The unified command is a bit more complicated, and I think it should be opened up to other contributors anyway.

@kastiglione
Copy link
Contributor

opened up to other contributors

Chisel contributions of awesome commands, but not many contributors do refactoring.

If these commands get merged, I'll @mention you when to give you the heads up 😉

Thanks!

@kastiglione kastiglione merged commit 381dff8 into facebook:master May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants