-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'pbundlepath' Print application's bundle directory path #152
Conversation
Thanks. I feel like it would be good to have just one command for "all" things path related. For example: Print docs path: Print bundle path: or, something like that. Although I said "all", for now we can handle just these two paths, and add any other paths later. By default, Thoughts? |
I originally wrote and shared this as a simple alias for use in an I can't think of any others paths that aren't closely relative to either of these two directories - so I don't see anyone having a good case for adding more ppath type commands. What do you think? |
I do like the idea of having options for these commands as shortcuts to particular directories of interest eg: Caches |
Ha, in saying that I do see how two commands for the different sets of interesting app directories could be confusing - even if they are grouped by which path they are relative to. :) (Sorry no edit on mobile github) |
it sounds like you're agreeing with the idea of one unified command, but I'm not 100% sure I'm interpreting your comments correctly… |
I'll try creating a unified command. Did you want to accept this PR as-is? |
Ideally we wouldn't introduce a command only to remove it shortly thereafter. If the unified command isn't going to happen any time soon, then yep I'll merge this. If you're aiming to soon work on the unified command, then I would hold off on this pull request. |
The unified command is a bit more complicated, and I think it should be opened up to other contributors anyway. |
Chisel contributions of awesome commands, but not many contributors do refactoring. If these commands get merged, I'll @mention you when to give you the heads up 😉 Thanks! |
Very similar to the existing
pdocspath
, this new commandpbundlepath
prints the path to the app bundle. Basically just[[NSBundle mainBundle] bundlePath]
but wrapped in a nice chisel command.