Skip to content

Commit

Permalink
fix: update envinfo + implementation, update issue_template
Browse files Browse the repository at this point in the history
# Conflicts:
#	packages/create-react-app/package.json
  • Loading branch information
tabrindle committed Apr 28, 2018
1 parent 458336b commit 22391ca
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 18 deletions.
17 changes: 8 additions & 9 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,18 @@
### Environment

<!--
Please fill in all the relevant fields by running these commands in terminal.
-->
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
1. `node -v`:
2. `npm -v`:
3. `yarn --version` (if you use Yarn):
4. `npm ls react-scripts` (if you haven’t ejected):
Run the following command in your react app's folder in terminal.
Note: The result is copied to your clipboard directly.
Then, specify:
`npx create-react-app --info`
1. Operating system:
2. Browser and version (if relevant):
Paste the output of the command in the section below.
-->

(paste the output of the command here)

### Steps to Reproduce

Expand Down
29 changes: 21 additions & 8 deletions packages/create-react-app/createReactApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,28 @@ const program = new commander.Command(packageJson.name)
})
.parse(process.argv);

if (program.info) {
console.log(chalk.bold('\nEnvironment Info:'));
return envinfo
.run(
{
System: ['OS', 'CPU'],
Binaries: ['Node', 'npm', 'Yarn'],
Browsers: ['Chrome', 'Firefox', 'Safari'],
npmPackages: ['react', 'react-dom', 'react-scripts'],
npmGlobalPackages: ['create-react-app'],
},
{
clipboard: true,
duplicates: true,
showNotFound: true,
}
)
.then(console.log)
.then(() => console.log(chalk.green('Copied To Clipboard!\n')));
}

if (typeof projectName === 'undefined') {
if (program.info) {
envinfo.print({
packages: ['react', 'react-dom', 'react-scripts'],
noNativeIDE: true,
duplicates: true,
});
process.exit(0);
}
console.error('Please specify the project directory:');
console.log(
` ${chalk.cyan(program.name())} ${chalk.green('<project-directory>')}`
Expand Down
2 changes: 1 addition & 1 deletion packages/create-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"chalk": "^1.1.3",
"commander": "^2.9.0",
"cross-spawn": "^4.0.0",
"envinfo": "3.4.2",
"envinfo": "5.2.0",
"fs-extra": "^5.0.0",
"hyperquest": "^2.1.2",
"react-dev-utils": "^5.0.0",
Expand Down

0 comments on commit 22391ca

Please sign in to comment.