Skip to content

Commit

Permalink
Use npm script hooks to avoid && in deploy script (#1324)
Browse files Browse the repository at this point in the history
  • Loading branch information
zpao authored and fson committed Dec 30, 2016
1 parent a90e2b2 commit 4d7b754
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion packages/react-scripts/scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ function build(previousSizeMap) {
console.log(' ' + chalk.dim('// ...'));
console.log(' ' + chalk.yellow('"scripts"') + ': {');
console.log(' ' + chalk.dim('// ...'));
console.log(' ' + chalk.yellow('"deploy"') + ': ' + chalk.yellow('"npm run build&&gh-pages -d build"'));
console.log(' ' + chalk.yellow('"predeploy"') + ': ' + chalk.yellow('"npm run build",'));
console.log(' ' + chalk.yellow('"deploy"') + ': ' + chalk.yellow('"gh-pages -d build"'));
console.log(' }');
console.log();
console.log('Then run:');
Expand Down
7 changes: 4 additions & 3 deletions packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1132,17 +1132,18 @@ To publish it at [https://myusername.github.io/my-app](https://myusername.github
npm install --save-dev gh-pages
```
Add the following script in your `package.json`:
Add the following scripts in your `package.json`:
```js
// ...
"scripts": {
// ...
"deploy": "npm run build&&gh-pages -d build"
"predeploy": "npm run build",
"deploy": "gh-pages -d build"
}
```
(Note: the lack of whitespace is intentional.)
The `predeploy` script will run automatically before `deploy` is run.
#### Step 3: Deploy the site by running `npm run deploy`
Expand Down

0 comments on commit 4d7b754

Please sign in to comment.