Skip to content

Commit

Permalink
Don't resolve localhost if on network (#2332)
Browse files Browse the repository at this point in the history
* Don't resolve if on network

* Update WebpackDevServerUtils.js
  • Loading branch information
Timer authored and gaearon committed May 24, 2017
1 parent 913689f commit a29808a
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion packages/react-dev-utils/WebpackDevServerUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,25 @@ function resolveLoopback(proxy) {
if (o.hostname !== 'localhost') {
return proxy;
}
try {
// Unfortunately, many languages (unlike node) do not yet support IPv6.
// This means even though localhost resolves to ::1, the application
// must fall back to IPv4 (on 127.0.0.1).
// We can re-enable this in a few years.
/*try {
o.hostname = address.ipv6() ? '::1' : '127.0.0.1';
} catch (_ignored) {
o.hostname = '127.0.0.1';
}*/

try {
// Check if we're on a network; if we are, chances are we can resolve
// localhost. Otherwise, we can just be safe and assume localhost is
// IPv4 for maximum compatibility.
if (!address.ip()) {
o.hostname = '127.0.0.1';
}
} catch (_ignored) {
o.hostname = '127.0.0.1';
}
return url.format(o);
}
Expand Down

0 comments on commit a29808a

Please sign in to comment.