We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No, Enhancement Request
If you've got serve already installed globally, asking users to install it becomes redundant.
serve
Current implementation is that the same instruction gets outputted, even though you'd have serve installed after running yarn build
yarn build
Use process.argv to map back to where the global folder is, or you could add global-prefix as a dependency.
process.argv
https://github.com/facebookincubator/create-react-app/blob/a171d930641f513279b1c7ceaab1fa9bbbbbb896/packages/react-dev-utils/printHostingInstructions.js#L124-L131
The text was updated successfully, but these errors were encountered:
I renamed because we have labels. Thanks for filing!
Sorry, something went wrong.
I'd love to submit a PR for this, do you think that the redundancy is just the line for installing serve? Or is it the whole section mentioning serve?
Will be fixed by #2761.
Nice @OwenFlood ! 🔥
No branches or pull requests
Is this a bug report?
No, Enhancement Request
Summary
If you've got
serve
already installed globally, asking users to install it becomes redundant.Example:
Current Implementation
Current implementation is that the same instruction gets outputted, even though you'd have
serve
installed after runningyarn build
Proposed
Use
process.argv
to map back to where the global folder is, or you could add global-prefix as a dependency.https://github.com/facebookincubator/create-react-app/blob/a171d930641f513279b1c7ceaab1fa9bbbbbb896/packages/react-dev-utils/printHostingInstructions.js#L124-L131
Happy hacking :)
The text was updated successfully, but these errors were encountered: