Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prompt to install serve if already installed #2761

Merged
merged 3 commits into from
Jul 10, 2017
Merged

Don't prompt to install serve if already installed #2761

merged 3 commits into from
Jul 10, 2017

Conversation

OwenFlood
Copy link
Contributor

This PR (#2750) removes the line prompting to install serve if the user already has it installed globally. Tested on Mac OS with and without serve installed.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 1.0.11 milestone Jul 10, 2017
@gaearon
Copy link
Contributor

gaearon commented Jul 10, 2017

Looks fine to me! Let's wait for CI to pass.
Thank you!

@gaearon gaearon mentioned this pull request Jul 10, 2017
Closed
@gaearon gaearon merged commit 3690495 into facebook:master Jul 10, 2017
@gurbraj
Copy link

gurbraj commented Jul 11, 2017

Wow, sick PR Owen.

Would push the 'owen-dank1' button if I could.

@Timer
Copy link
Contributor

Timer commented Aug 9, 2017

Hi there! This change is out in [email protected]; please give it a go! Thanks.

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017
@OwenFlood @JohnNilsson
Don't prompt to install serve if already installed (#2761)
7743519 
* dont prompt if serve is already installed

* change name for readability

* Pin the version
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@OwenFlood @morgs32
Don't prompt to install serve if already installed (facebook#2761)
ce990a7 
* dont prompt if serve is already installed

* change name for readability

* Pin the version
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017
@OwenFlood @JohnNilsson
Don't prompt to install serve if already installed (#2761)
5eb7c73 
* dont prompt if serve is already installed

* change name for readability

* Pin the version
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@OwenFlood @kasperpeulen
Don't prompt to install serve if already installed (facebook#2761)
31695a3 
* dont prompt if serve is already installed

* change name for readability

* Pin the version
swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017
@OwenFlood @swengorschewski
Don't prompt to install serve if already installed (#2761)
a851405 
* dont prompt if serve is already installed

* change name for readability

* Pin the version
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.0.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OwenFlood @facebook-github-bot @gaearon @gurbraj @Timer