Make PUBLIC_URL environment variable available at build time. #1128
Conversation
Previously PUBLIC_URL was read from package.json homapage entry. Webpack DefinePlugin then processed the PUBLIC_URL to be available at run time. However setting environment variable should have precedence over configuration. Fixed by looking into process.env.PUBLIC_URL before assiging value from package.json.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Okay, sorry for the hassle! |
Previously PUBLIC_URL was read from package.json homepage entry. Webpack DefinePlugin then processed the PUBLIC_URL to be available at runtime. However setting the environment variable should have precedence over configuration. Currently setting the PUBLIC_URL has no effect. This can be very confusing for a developer.
Fixed by looking into process.env.PUBLIC_URL before assigning a value from package.json.
Test plan:
$ export PUBLIC_URL=testing && npm run buildYou should immediately see from the output if create-react-app picked it up.