Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add missing .cjs extension to babel loader test in the webpack config #12578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ldeninski
Copy link

This PR adds the missed .cjs extension to the webpack config loader section. According to webpack docs found here to force the module type of a file you can use the .cjs extension similarly to .mjs for ESM. Without this extension explicitly added to the loader test rule, packages using .cjs file as a main in there package.json will not work at all. The index.cjs file is picked up by the file loader and treated as an asset. A good example of this behavior are all prosemirror packages witch are not usable in CRA app.

I tested my changes on a the codebase of a relatively complex project I am working on and the change is not breaking anything so far. Sorry but I cannot share screens from this project :)

@ldeninski ldeninski requested a review from mrmckeb as a code owner July 8, 2022 21:02
@facebook-github-bot
Copy link

Hi @ldeninski!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants