Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow if react-scripts package is linked via npm-link #1356

Merged
merged 6 commits into from
Feb 24, 2017
Merged

Fix workflow if react-scripts package is linked via npm-link #1356

merged 6 commits into from
Feb 24, 2017

Commits on Feb 15, 2017

  1. add npm-link support

    @tuchk4
    tuchk4 committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    d66f3fd View commit details
    Browse the repository at this point in the history

  2. - remove extra veriable 

    - simplify condition
    @tuchk4
    tuchk4 committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    4e91cb3 View commit details
    Browse the repository at this point in the history

  3. update code after review: 

    - remove utils/isReactScriptsLinked
- add appPath and ownPath to paths.js (but only for "before eject" export case)
    @tuchk4
    tuchk4 committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    d654784 View commit details
    Browse the repository at this point in the history

  4. update code after review: 

    - remove utils/isReactScriptsLinked
- add appPath and ownPath to paths.js (but only for "before eject" export case)
    @tuchk4
    tuchk4 committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    f23bdbd View commit details
    Browse the repository at this point in the history

  5. update code after review: 

    - remove utils/isReactScriptsLinked
- add appPath and ownPath to paths.js (but only for "before eject" export case)
- remove "if" block for fs.removeSync(ownPath) at ejec.tjs
    @tuchk4
    tuchk4 committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    3f2c3b4 View commit details
    Browse the repository at this point in the history

  6. change ownPath value

    @tuchk4
    tuchk4 committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    927e3a0 View commit details
    Browse the repository at this point in the history