-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use offline cached version with yarn when it's possible #1423
Merged
gaearon
merged 9 commits into
facebook:master
from
voxsim:use-offline-version-when-it-is-possible
Feb 28, 2017
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
efb8eea
add --offline flag when we are using yarn and we are offline
voxsim 3437e65
Merge branch 'master' into use-offline-version-when-it-is-possible
gaearon 0a2c71a
Revert changes to init script
gaearon 9b60cc1
Don't pass isOnline to init script because it doesn't need it
gaearon 90af8c2
Don't ping the Yarn registry if user doesn't have Yarn
gaearon 0f8e08e
Remove unused/wrong arguments
gaearon c9cece5
Move logs to error handler
gaearon ea856e3
Fix error handling
gaearon 1445662
Report to the user that they're offline
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move it back command and args or pass command + ' ' + args.join(' ') as parameter of reject because it breaks here otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am referring about this commit c9cece5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, fixed.