-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily fork detect-port #2147
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/** | ||
* Copyright (c) 2015-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const debug = require('debug')('detect-port'); | ||
const net = require('net'); | ||
|
||
module.exports = (port, host, callback) => { | ||
if (typeof port === 'function') { | ||
callback = port; | ||
port = null; | ||
} | ||
port = parseInt(port) || 0; | ||
let maxPort = port + 10; | ||
if (maxPort > 65535) { | ||
maxPort = 65535; | ||
} | ||
debug('detect free port between [%s, %s)', port, maxPort); | ||
if (typeof callback === 'function') { | ||
return tryListen(host, port, maxPort, callback); | ||
} | ||
// promise | ||
return new Promise(resolve => { | ||
tryListen(host, port, maxPort, (_, realPort) => { | ||
resolve(realPort); | ||
}); | ||
}); | ||
}; | ||
|
||
function tryListen(host, port, maxPort, callback) { | ||
const server = new net.Server(); | ||
|
||
server.on('error', err => { | ||
debug('listen %s error: %s', port, err); | ||
if (port === 0) { | ||
return callback(err); | ||
} | ||
|
||
port++; | ||
if (port >= maxPort) { | ||
debug( | ||
'port: %s >= maxPort: %s, give up and use random port', | ||
port, | ||
maxPort | ||
); | ||
port = 0; | ||
maxPort = 0; | ||
} | ||
server.close(); | ||
return tryListen(host, port, maxPort, callback); | ||
}); | ||
|
||
server.listen({ port, host }, () => { | ||
port = server.address().port; | ||
server.close(); | ||
debug('get free port: %s', port); | ||
callback(null, port); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have the original license, not FB's.
Unfortunately this makes our situation more complicated as I'd like to avoid mixing licenses in one package.
Ideally we should either use original package, or use a fork from either of our personal repos (so that we don't bring a different license here).
While we're looking at it, can we check what Zeit's
serve
uses? Maybe we can just use that (since I think it worked with0.0.0.0
fine).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was going to ask you about the licensing before merging. It's MIT.
Serve uses
detect-port
, meaning it has the same issue we do.