Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebStorm >2017 launchEditor Support #2414

Merged
merged 1 commit into from
May 30, 2017

Conversation

wirmar
Copy link
Contributor

@wirmar wirmar commented May 30, 2017

WebStorm changed the format to open files from the command line in the latest versions.

Relates to #2406.

https://www.jetbrains.com/help/webstorm/2017.1/opening-files-from-command-line.html

Tested manually on my windows machine.

@gaearon gaearon added this to the 1.0.8 milestone May 30, 2017
@gaearon gaearon merged commit 02f88ba into facebook:master May 30, 2017
@gaearon
Copy link
Contributor

gaearon commented May 30, 2017

This looks great. Thank you!

zangrafx added a commit to zangrafx/create-react-app that referenced this pull request May 31, 2017
* master:
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)
@gaearon gaearon mentioned this pull request Jun 28, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants