Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - Remove service worker #2441

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1366,10 +1366,12 @@ Learn more about React Storybook:

## Making a Progressive Web App

By default, the production build is a fully functional, offline-first
[Progressive Web App](https://developers.google.com/web/progressive-web-apps/).
**The Progressive Web App and Service Workers feature is currently disabled and will re-enabled after modificatioons.**

Progressive Web Apps are faster and more reliable than traditional web pages, and provide an engaging mobile experience:
~~By default, the production build is a fully functional, offline-first
Progressive Web App.~~

[Progressive Web Apps](https://developers.google.com/web/progressive-web-apps/) are faster and more reliable than traditional web pages, and provide an engaging mobile experience:

* All static site assets are cached so that your page loads fast on subsequent visits, regardless of network connectivity (such as 2G or 3G). Updates are downloaded in the background.
* Your app will work regardless of network state, even if offline. This means your users will be able to use your app at 10,000 feet and on the Subway.
Expand Down Expand Up @@ -1453,6 +1455,8 @@ option in the `SWPrecacheWebpackPlugin` section of

### Progressive Web App Metadata

**The Progressive Web App and Service Workers feature is currently disabled and will re-enabled at a later date**

The default configuration includes a web app manifest located at
[`public/manifest.json`](public/manifest.json), that you can customize with
details specific to your web application.
Expand Down
2 changes: 0 additions & 2 deletions packages/react-scripts/template/src/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';
import registerServiceWorker from './registerServiceWorker';
import './index.css';

ReactDOM.render(<App />, document.getElementById('root'));
registerServiceWorker();