Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage for Serve 7 #4532

Closed
wants to merge 1 commit into from
Closed

Conversation

nickserv
Copy link
Contributor

Serve has some breaking changes. Most of the command line options including -s and -p have been removed or replaced with a config file. For the sake of simplicity I decided to remove info about non-defaults, but we could link to the docs on rewrite configs (which replace -s) somewhere: https://github.com/zeit/serve-handler#rewrites-array

@gaearon
Copy link
Contributor

gaearon commented May 29, 2018

Oh dear. Now the build output instructions hardcoded into every existing CRA app is wrong.

cc @leo Any chance we could heads up next time? If I recall correctly someone from Zeit sent a PR to us so we start recommending serve. This is quite frustrating for us now.

@gaearon
Copy link
Contributor

gaearon commented May 29, 2018

To be clear, we can take this in theory, but:

  1. There are old majors of react-dev-utils that are a pain to update
  2. People who ejected (about half of our users?) will get a pinned version of react-dev-utils and won’t guess they need to bump the version

@gaearon
Copy link
Contributor

gaearon commented May 29, 2018

Also, a config file is pretty much a showstopper for us. We’d have to move back to pushstate-server I guess.

@gaearon
Copy link
Contributor

gaearon commented May 29, 2018

I filed vercel/serve#382. I don't think this particular solution works for us, but thank you for sending it.

@gaearon gaearon closed this May 29, 2018
@leo
Copy link
Contributor

leo commented May 29, 2018

This is now solved, as per this. You can use -l <port> for setting the port and --single (just like before) for getting a rewrite-preset for serving an SPA.

Sorry for the inconvenience we've caused!

@nickserv nickserv deleted the serve-docs branch September 2, 2018 00:06
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants