Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use cached yarn.lock if using the default yarn registry #5745

Closed
wants to merge 4 commits into from
Closed

Only use cached yarn.lock if using the default yarn registry #5745

wants to merge 4 commits into from

Conversation

timsnadden
Copy link

Yarn users who have a custom registry setting should not get the yarn.lock.cached file. See [#5270]

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@timsnadden
Copy link
Author

These CI failures are not directly related to the change made. I don't know what to do about that

@timsnadden
Merge branch 'master' into checkYarnRegistry
fb0b775 
* master: (39 commits)
  Added extension to .eslintrc (facebook#5988)
  Update links to docs in all package README files (facebook#5912)
  Use https for linked images in docs to fix mixed content warnings (facebook#5985)
  Improve error messaging in verifyPackageTree.js (facebook#5974)
  Add removeItem to localStorage mock in docs (facebook#5919)
  Add SASS_PATH instructions to Sass docs (facebook#5917)
  Suggest a different default for speed reasons (facebook#5959)
  Add pre-eject message about new features in v2 (facebook#5954)
  Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930)
  Correct some comments (facebook#5927)
  Add note to docs about using Sass and Flow together (facebook#5823)
  Update PWA link in README (facebook#5907)
  Add placeholders to template README for bit.ly links. (facebook#5808)
  Disable copy to clipboard in cra --info (facebook#5905)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  ...
@timsnadden timsnadden mentioned this pull request Dec 7, 2018
Closed
@NMinhNguyen @timsnadden
Update packages/create-react-app/createReactApp.js
abc2e59 
Co-Authored-By: timsnadden <tim@snadden.com>
@meo8 meo8 mentioned this pull request Jan 23, 2019
Merged
@ianschmitz
Copy link
Contributor

Closing in favor of #6253

@ianschmitz ianschmitz closed this Feb 18, 2019
@timsnadden timsnadden deleted the checkYarnRegistry branch February 19, 2019 05:04
@lock lock bot locked and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NMinhNguyen NMinhNguyen NMinhNguyen left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timsnadden @facebook-github-bot @ianschmitz @NMinhNguyen