InlineChunkHtmlPlugin works with empty publicPath

[ItalyPaleAle]

The InlineChunkHtmlPlugin plugin didn't work when the publicPath variable is empty or unset (e.g. when I want to use relative URLs).

Before:

• If publicPath was unset or wasn't a string, webpack would throw an error
• If publicPath was an empty string, the plugin would fail to inline a chunk

Now: the plugin behaves as expected even with empty or unset publicPath.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[Timer]

n.b. for other reviewers, this is not a bug. It only affects users who eject from Create React App or use our plugins in non-CRA applications.

[ItalyPaleAle]

I mean, it is a bug. It just happens to only affect people who eject from CRA (like my case). Still, it's not less of a bug :)

[ItalyPaleAle]

@Timer any update on this? When can it be merged?

[ItalyPaleAle]

Ping :)

[iansu]

Thanks!