Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more sophisticated template for end-to-end testing. #875

Closed
wants to merge 1 commit into from

Conversation

wdhorton
Copy link
Contributor

@wdhorton wdhorton commented Oct 8, 2016

This addresses #706. The features that I've included in the kitchensink template so far are:

  • JSX (technically the normal template was already using it for divs and stuff, but this tests it for custom components, and passing props)
  • Flow
  • NODE_PATH
  • generators
  • async/await
  • class properties
  • custom env variables via shell and .env file (though with the current testing setup it only tests that these don't make the app crash on build and start, rather than whether they actually get through)

Test Plan: ran e2e.sh, confirmed it used the kitchensink template, and it ran to the end with no errors.

Let me know if there are any other features I should add in, or if I should show more advanced usage of the ones listed above.

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

Sorry it took so long to review.
Is there any way we can exclude this from actually being shipped to our users in the npm package?

@gaearon
Copy link
Contributor

gaearon commented Feb 11, 2017

This PR was cherry-picked and merged as part of #1187.
Thank you so much for contributing!

@gaearon gaearon closed this Feb 11, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants