Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for postcss.config.js #8907

Closed
wants to merge 1 commit into from

Conversation

piecyk
Copy link

@piecyk piecyk commented Apr 26, 2020

This pull request addressed the issue of supporting custom postcss.config.js. It's third one after #8474 #8331 🙈

Basic idea here is to check if we have config same way postcss-loader does.

@facebook-github-bot
Copy link

Hi @piecyk!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@pspeter3
Copy link

pspeter3 commented May 7, 2020

What's the difference between this an #8331?

@piecyk
Copy link
Author

piecyk commented May 7, 2020

@pspeter3 here we use the same logic as postcss-loader to resolve config using postcss-load-config. #8331 is checking it by hand using cosmiconfig.

@piecyk piecyk force-pushed the feature/postcss-config branch 2 times, most recently from 4d4bc0b to 0d0c6be Compare May 7, 2020 20:14
@pspeter3
Copy link

pspeter3 commented May 7, 2020

Cool! Well hopefully this gets accepted. It would be nice to override the PostCSS config.

@piecyk piecyk force-pushed the feature/postcss-config branch 2 times, most recently from f5223a9 to 0feb76b Compare May 20, 2020 13:21
…ptions

- Update post-processing-css.md
- Add test
- Add postcss-load-config as react-scripts dependency
@piecyk
Copy link
Author

piecyk commented May 20, 2020

Should be ready 👋

@piecyk
Copy link
Author

piecyk commented May 27, 2020

ping @ianschmitz @mrmckeb

@stale
Copy link

stale bot commented Jun 26, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jun 26, 2020
@piecyk
Copy link
Author

piecyk commented Jun 26, 2020

Maybe not stale? 🤷‍♂️

@stale stale bot removed the stale label Jun 26, 2020
@mxkxf
Copy link
Contributor

mxkxf commented Jun 26, 2020

I have everything crossed this makes it into the next version 🤞

@stale
Copy link

stale bot commented Jul 26, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 26, 2020
@alexlanz
Copy link

Please don't close this PR!! This would help us a lot. We are looking forward to see custom postcss configurations

@stale stale bot removed the stale label Jul 27, 2020
@amyrlam amyrlam removed their request for review August 24, 2020 05:39
@piecyk
Copy link
Author

piecyk commented Aug 24, 2020

@iansu @gaearon would you mind taking a look once you have a moment 🙏

@pspeter3
Copy link

pspeter3 commented Sep 9, 2020

This would be a huge win, especially with recent popularity of Tailwind which requires a PostCSS configuration file.

Copy link

@Ishaan28malik Ishaan28malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piecyk piecyk mentioned this pull request Oct 1, 2020
@tomspeak
Copy link

Is it possible to get any insight into when this could potentially be released? Soon? Next major release?

@geekdada
Copy link

This really helps a lot!

@max8hine
Copy link

It would be great that the user can in charge of the PostCSS build.

@sahilpurav
Copy link
Contributor

This is a great feature! I was hoping to build it if it isn't initiated.

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2020
@marco-carvalho
Copy link

don't close this PR!

@stale stale bot removed the stale label Dec 28, 2020
@joshmanders
Copy link

Any update on this?

@GeoffSelby
Copy link

GeoffSelby commented Jan 11, 2021

Any update on this?

@joshmanders I don’t see it happening anytime soon. That’s why I made a custom fork and implemented it myself.

Using my fork with my cra-template-tailwindcss template is the way to go if you are looking for create react app with tailwind support 👍

@joshmanders
Copy link

@GeoffSelby oh I didn't know you made one. I keep checking back on CRA about having more support for things and see it's always just PR or Issue after PR/Issue with no updates or feedback.

May as well just stay with Next.js

@piecyk
Copy link
Author

piecyk commented Mar 31, 2021

Resolved via #10003

@piecyk piecyk closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.