Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page doesn't get refreshed when FAST_REFRESH=false #9884

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

n3tr
Copy link
Contributor

@n3tr n3tr commented Oct 24, 2020

Page doesn't get refreshed when disabling FAST_REFRESH. This is because the process.env.FAST_REFRESH in webpackHotDevClient is a boolean value, comparing !== 'false' will always return true.

Verify steps

  • yarn create-react-app my-app
  • yarn start
  • Modify App.js content
  • The app gets updated through Fast Refresh

FAST_REFRESH=false

  • Start the app by using FAST_REFRESH=false yarn start
  • Modify App.js
  • The app should do a full reload

@ianschmitz ianschmitz changed the title [v4] Fix page doesn't get refreshed when FAST_REFRESH=false fix: page doesn't get refreshed when FAST_REFRESH=false Oct 26, 2020
@ianschmitz ianschmitz merged commit 7e48117 into facebook:master Oct 26, 2020
@ianschmitz
Copy link
Contributor

Great find. Thanks!

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants