Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@docusaurus/eslint-plugin] Add plugin setting to recommended eslint config #8280

Closed
2 tasks done
lachieh opened this issue Nov 2, 2022 · 0 comments · Fixed by #8281
Closed
2 tasks done

[@docusaurus/eslint-plugin] Add plugin setting to recommended eslint config #8280

lachieh opened this issue Nov 2, 2022 · 0 comments · Fixed by #8281
Labels
proposal This issue is a proposal, usually non-trivial change

Comments

@lachieh
Copy link
Contributor

lachieh commented Nov 2, 2022

Have you read the Contributing Guidelines on issues?

Motivation

In the documentation for the eslint-plugin, the instructions mention that it is a requirement to add the plugin to the project's eslint config before the plugin:@docusaurus/recommended config can be added.

It is pretty standard now to have the recommended configuration add the plugin into the recommended config so that adding the appropriate plugin happens automatically:

I am suggesting that the same change be implemented in this plugin as well. This will allow for easier configuration and better alignment to community patterns.

Self-service

  • I'd be willing to do some initial work on this proposal myself.
@lachieh lachieh added proposal This issue is a proposal, usually non-trivial change status: needs triage This issue has not been triaged by maintainers labels Nov 2, 2022
@Josh-Cena Josh-Cena removed the status: needs triage This issue has not been triaged by maintainers label Dec 3, 2022
slorber pushed a commit that referenced this issue Dec 7, 2022
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
closes undefined
Closes #8280
slorber pushed a commit that referenced this issue Jan 26, 2023
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
closes undefined
Closes #8280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants