fix(core): fix docusaurus serve broken for assets when using trailingSlash
#10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
slorber
changed the title
docusaurus serve is broken for assetsdocusaurus serve broken for assets when using trailingSlash
msyfls123
reviewed
May 16, 2024
| if (baseUrl !== '/') { | ||
| // Not super robust, but should be good enough for our use case | ||
| // See https://github.com/facebook/docusaurus/pull/10090 | ||
| const looksLikeAsset = !!req.url.match(/.[a-z]{1,4}$/); |
There was a problem hiding this comment.
Good point, not sure why I assumed extensions could only contain lowercase letters 😅
tas50
added a commit
to mondoohq/docs
that referenced
this pull request
May 31, 2024
This fixed our trailing slash bug via facebook/docusaurus#10142 Signed-off-by: Tim Smith <tsmith84@gmail.com>
8 tasks
misterpantz
pushed a commit
to mondoohq/docs
that referenced
this pull request
May 31, 2024
This fixed our trailing slash bug via facebook/docusaurus#10142 Signed-off-by: Tim Smith <tsmith84@gmail.com>
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #10139
The workaround applied in #10090 lead to a regression for serving assets. I'm now applying this workaround more defensively.
The workaround impl is not 100% robust but should work fine for 99.9% of websites and only applies to sites using
docusauris servewith a baseurl + trailingSlash.Test Plan
no 😅 it works locally