Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): change casing of some en labels #10394

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

cstangerup
Copy link
Contributor

@cstangerup cstangerup commented Aug 12, 2024

Pre-flight checklist

Motivation

Some strings don't seem to match the overall semantics of Docusaurus. This PR aims to correct the given translation strings by converting them from pascal case to normal capitalization. Please correct me if this was done intentionally.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 12, 2024
Copy link

netlify bot commented Aug 12, 2024

[V2]

Name Link
🔨 Latest commit 8327b86
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66bb45ee113d010008544fb6
😎 Deploy Preview https://deploy-preview-10394--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 12, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 44 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🔴 48 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 67 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 68 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber
Copy link
Collaborator

slorber commented Aug 12, 2024

I think this has been done this way historically on purpose.

Not sure we are willing to change that right now, considering all those labels can be overridden by users and nobody complained so far about the defaults.

@Josh-Cena I'm sure you have an opinion on this 😄

@Josh-Cena
Copy link
Collaborator

I don't remember this ever being a conscious decision (and even if there was, it predated me since most of these are ancient features). That said, I'm +1 on this change to use sentence-case everywhere.

@Josh-Cena Josh-Cena changed the title fix(translations): Alter common translations fix(translations): change casing of some en labels Aug 12, 2024
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 12, 2024
@slorber
Copy link
Collaborator

slorber commented Aug 13, 2024

Ok let's merge this then, and hope users wont complain about the change.

In case you want to restore former behavior:

  • use docusaurus write-translations CLI and change the labels in website/i18n/code.json
  • use CSS text-transform: capitalize

@slorber slorber merged commit a1edf51 into facebook:main Aug 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants