Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add caveat about using Translate in string contexts #8115

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Brought up in #8104. I think this can be explicitly spelled out.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 19, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 19, 2022
@netlify
Copy link

netlify bot commented Sep 19, 2022

[V2]

Name Link
🔨 Latest commit d749a9d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6328812758276900093092f0
😎 Deploy Preview https://deploy-preview-8115--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 87 🟢 100 🟢 100 🟢 100 🟢 90 Report

@netlify
Copy link

netlify bot commented Sep 19, 2022

[V2]

Name Link
🔨 Latest commit a8756ed
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/632881f8db05d000098c4208
😎 Deploy Preview https://deploy-preview-8115--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena Josh-Cena merged commit 6514f07 into main Sep 19, 2022
@Josh-Cena Josh-Cena deleted the translate-caveat branch September 19, 2022 14:59
@github-actions
Copy link

Size Change: 0 B

Total Size: 814 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.1 kB
website/build/assets/css/styles.********.css 112 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 40.8 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants