Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): log missing errorInfo in React 18 onRecoverableError callback #9387

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix(core): log missing errorInfo in React 18 onRecoverableError callback #9387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef20342
feat: log errorInfo from onRecoverableError
johnnyreilly Oct 9, 2023
16dd756
use ReactDOM ErrorInfo type
slorber Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/docusaurus/src/client/clientEntry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import React from 'react';
import ReactDOM from 'react-dom/client';
import ReactDOM, {type ErrorInfo} from 'react-dom/client';
import {BrowserRouter} from 'react-router-dom';
import {HelmetProvider} from 'react-helmet-async';

Expand Down Expand Up @@ -37,8 +37,12 @@ if (ExecutionEnvironment.canUseDOM) {
</HelmetProvider>
);

const onRecoverableError = (error: unknown): void => {
console.error('Docusaurus React Root onRecoverableError:', error);
const onRecoverableError = (error: unknown, errorInfo: ErrorInfo): void => {
console.error(
'Docusaurus React Root onRecoverableError:',
error,
errorInfo,
);
};

const renderApp = () => {
Expand Down
Loading