Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

montblanc: config: add port 65 in dvt qsfp config #221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhongedward
Copy link

@zhongedward zhongedward commented Sep 6, 2024

Description
This PR is for montblanc dvt qsfp config.

Motivation
1.In montblanc dvt machine has added port 65,so we need to add it in qsfp.conf file.
2.Test cmd:

test cmd:
[root@localhost main_137]# LD_LIBRARY_PATH=./fboss_lib/ ./qsfp_hw_test --qsfp-config qsfp_65.conf --gtest_filter=HwTest.i2cStressRead:HwTest.i2cStressWrite:HwTest.cmisPageChange:HwTest.i2cUniqueSerialNumbers --bsp_platform_mapping_override_path ./montblanc_bsp_mapping_dvt_all_port_65.json

Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.This PR has used "jq" cmd to pretty the format.
3.Test log as follow:

354143316-2db530f0-a48f-48b2-ae21-e336b2352c74

mp3_dvt_oss_test_qsfp_hw_test_all_65port_test_log_7_30.txt

@facebook-github-bot
Copy link
Contributor

Hi @zhongedward!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@zhongedward zhongedward changed the title montblanc: config: add port 65 in dvt qsfp config montblanc: config: add port 65 in dvt osfp config Sep 6, 2024
@zhongedward zhongedward changed the title montblanc: config: add port 65 in dvt osfp config montblanc: config: add port 65 in dvt qsfp config Sep 6, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zhongedward has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants