Use modern Podfile syntax to avoid polluting application build settings #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example warning ``` Can't merge user_target_xcconfig for pod targets: ["RNReanimated", "hermes-engine"]. Singular build setting CLANG_CXX_LANGUAGE_STANDARD has different values. ``` Background: > The former attribute xcconfig is deprecated and will cause a linter error when pushing new versions to trunk. The new attributes are available as pod_target_xcconfig and user_target_xcconfig, which makes their effects more clear. The latter attribute (user_target_xcconfig) should be used with great care, because well designed Pods should be self-contained and make as few assumptions about their environment as possible. Furthermore, this attribute can cause conflicts when different values are specified by two Pods for a build setting which doesn't allow multiple values and so cannot be merged. - https://blog.cocoapods.org/CocoaPods-0.38/
facebook-github-bot
added
the
CLA Signed
|
Hmm, probably need HERMES_ENABLE_DEBUGGER in test app |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 25, 2023
…gs (#35954) Summary: Fixes conflicts in pod build settings like the one below: Example warning > Can't merge user_target_xcconfig for pod targets: ["RNReanimated", "hermes-engine"]. Singular build setting CLANG_CXX_LANGUAGE_STANDARD has different values. Background: > The former attribute xcconfig is deprecated and will cause a linter error when pushing new versions to trunk. The new attributes are available as pod_target_xcconfig and user_target_xcconfig, which makes their effects more clear. The latter attribute (user_target_xcconfig) should be used with great care, because well designed Pods should be self-contained and make as few assumptions about their environment as possible. Furthermore, this attribute can cause conflicts when different values are specified by two Pods for a build setting which doesn't allow multiple values and so cannot be merged. - https://blog.cocoapods.org/CocoaPods-0.38/ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [FIXED] - Fix cocoapods warning about merging user_target_xcconfig --> Pull Request resolved: #35954 Test Plan: - Run in example app ## Related PR - facebook/hermes#903 Reviewed By: christophpurrer Differential Revision: D42737921 Pulled By: jacdebug fbshipit-source-id: 75d087a5287e660a703342d6e0ad6632f05f3c4c
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…gs (facebook#35954) Summary: Fixes conflicts in pod build settings like the one below: Example warning > Can't merge user_target_xcconfig for pod targets: ["RNReanimated", "hermes-engine"]. Singular build setting CLANG_CXX_LANGUAGE_STANDARD has different values. Background: > The former attribute xcconfig is deprecated and will cause a linter error when pushing new versions to trunk. The new attributes are available as pod_target_xcconfig and user_target_xcconfig, which makes their effects more clear. The latter attribute (user_target_xcconfig) should be used with great care, because well designed Pods should be self-contained and make as few assumptions about their environment as possible. Furthermore, this attribute can cause conflicts when different values are specified by two Pods for a build setting which doesn't allow multiple values and so cannot be merged. - https://blog.cocoapods.org/CocoaPods-0.38/ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [FIXED] - Fix cocoapods warning about merging user_target_xcconfig --> Pull Request resolved: facebook#35954 Test Plan: - Run in example app ## Related PR - facebook/hermes#903 Reviewed By: christophpurrer Differential Revision: D42737921 Pulled By: jacdebug fbshipit-source-id: 75d087a5287e660a703342d6e0ad6632f05f3c4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes conflicts in pod build settings like the one below:
Example warning
Background:
Test Plan
Build in ApplePlatformsIntegrationMacTests
Related PR