Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when creating a link #35

Open
damirstuhec opened this issue Sep 20, 2023 · 3 comments
Open

Crash when creating a link #35

damirstuhec opened this issue Sep 20, 2023 · 3 comments

Comments

@damirstuhec
Copy link
Contributor

I'm experimenting with the latest version of LexicalPlayground and running into a crash when applying a link to the selected text. Details below. Please let me know if you need more info.

Steps to reproduce

  1. Type "Hello world".
  2. Select "world".
  3. Tap the link button in the top toolbar.
  4. Write any valid URL.
  5. Tap "Done" to apply the link.
  6. Crash. (in TextStorage.swift)💥

Assets

Screenshot 2023-09-20 at 15 19 13
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-09-20.at.15.22.43.mp4
@amyworrall
Copy link
Contributor

Hi. Two points:

  • I've just fixed a crash and a bug in the Link playground feature, see PRs Fix crash inside extract() #36 and Link plugin in toolbar now works without selection #37. I think I might have worked around what's happening in your case, but I'm not sure I've got to the root cause yet.
  • Can I ask which iOS version you're testing on? I didn't see these issues until iOS 17, so I'm wondering if something has changed in UIKit/TextKit which we need to take account of.

@damirstuhec
Copy link
Contributor Author

I'm testing on iOS 17.

@mansimransingh
Copy link
Contributor

I think I found this bug too. Fixed in: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants