Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link plugin in toolbar now works without selection #37

Closed
wants to merge 2 commits into from
Closed

Conversation

amyworrall
Copy link
Contributor

@amyworrall amyworrall commented Sep 20, 2023

Link plugin in toolbar now works without selection


Stack created with Sapling. Best reviewed with ReviewStack.

@facebook-github-bot
Copy link
Contributor

@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 25, 2023
Summary:
Fix crash inside extract()

 ---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/lexical-ios/pull/36).
* #37
* __->__ #36

Pull Request resolved: #36

Reviewed By: zurfyx

Differential Revision: D49461037

Pulled By: amyworrall

fbshipit-source-id: c13da24cc7fd886e95c3f4d613acf61bcac25cb5
@facebook-github-bot
Copy link
Contributor

@amyworrall merged this pull request in 4738571.

amyworrall pushed a commit that referenced this pull request Oct 6, 2023
amyworrall pushed a commit that referenced this pull request Oct 6, 2023
facebook-github-bot pushed a commit that referenced this pull request Oct 6, 2023
Summary:
FIX for marked text, broken in PR #37

Pull Request resolved: #45

Test Plan: Tested in Lexical playground.

Reviewed By: zurfyx

Differential Revision: D50011925

Pulled By: amyworrall

fbshipit-source-id: cf76d0b104f9f55597d229445a7e4a5cca3a8fd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants