Serialize tree structure in file map cache #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46598820 |
Differential Revision: D45446791 fbshipit-source-id: 61de2b40a7c8e4fd9f65c1cb69fa8367b7ec4bcc
Differential Revision: https://internalfb.com/D46495960 fbshipit-source-id: b5922a6fc8e22e7763bcb33d6de0b7d26ea83d77
…leData` Differential Revision: https://internalfb.com/D46515321 fbshipit-source-id: 0e9b77e238733ae477f12eb921c7f3eae9dc0bf1
Differential Revision: D45446644 fbshipit-source-id: 1d5b8aa542c81624a96d84476b78b62f2a5debe2
Differential Revision: https://internalfb.com/D46261693 fbshipit-source-id: 9e0b93f3a096ff14aec947590df0c59510cd9ca6
Differential Revision: https://internalfb.com/D46682954 fbshipit-source-id: a29ced630e00695e970fc83c770333f204ad1d80
Differential Revision: D46767544 fbshipit-source-id: e7643ed1e11cf6b811a7f5b88493b0e2e9a5507a
Differential Revision: D46802785 fbshipit-source-id: 42e9b73c19296af5729a5a3aa09faf2449335d63
Differential Revision: D46687190 fbshipit-source-id: 8f80558509c86c256b3ca4261338d6d43b830e6d
Summary: Pull Request resolved: facebook#1006 Serialise `metro-file-map`'s `TreeFS` by cloning the tree, instead of converting to and from a flat `Map`. - Cache `fileSystemData` is now fully cross-platform (it contains no path separators). - Serialised data is now a closer match with the internal representation. The new structure is as fast to write, faster to read, and smaller. Changelog: ``` - **[Performance]**: Improved startup speed via a new file map cache format. ``` Reviewed By: motiz88 Differential Revision: D46598820 fbshipit-source-id: 40c0022a23b639fb81374356fb9a40ca6ad10f20
robhogan
force-pushed
the
export-D46598820
branch
from
6e2c088
to
342387c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46598820 |
|
This pull request has been merged in 166477e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Serialise
metro-file-map'sTreeFSby cloning the tree, instead of converting to and from a flatMap.fileSystemDatais now fully cross-platform (it contains no path separators).Changelog:
Differential Revision: D46598820