draft implementation of android_errorMessage

facebook · Mar 12, 2022 · 60b6c9b · 60b6c9b
1 parent a4ef7a7
commit 60b6c9b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js
@@ -402,6 +402,14 @@ type AndroidProps = $ReadOnly<{|
    */
   disableFullscreenUI?: ?boolean,
 
+  /**
+   * String to be read by screenreaders to indicate an error state. If this value is
+   * not null, an error will be announced. You can use onChangeText or onBlur to
+   * detect an error and set this prop. Once the error is gone, set this to null
+   * to clear the error
+   */
+  android_errorMessage?: ?Stringish,
+
   importantForAutofill?: ?(
     | 'auto'
     | 'no'
@@ -1281,7 +1289,6 @@ function InternalTextInput(props: Props): React.Node {
        * match up exactly with the props for TextInput. This will need to get
        * fixed */
       <AndroidTextInput
-        error="Fabrizio! Why did you make a mistake?
         ref={_setNativeRef}
         {...props}
         {...eventHandlers}

diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.java
@@ -84,7 +84,7 @@ public class ViewProps {
   public static final String BACKGROUND_COLOR = "backgroundColor";
   public static final String FOREGROUND_COLOR = "foregroundColor";
   public static final String COLOR = "color";
-  public static final String ERROR = "error";
+  public static final String ERROR_MESSAGE = "error";
   public static final String FONT_SIZE = "fontSize";
   public static final String FONT_WEIGHT = "fontWeight";
   public static final String FONT_STYLE = "fontStyle";

diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
@@ -372,8 +372,8 @@ public void updateExtraData(ReactEditText view, Object extraData) {
     }
   }
 
-  @ReactProp(name = ViewProps.ERROR)
-  public void setError(ReactEditText view, String error) {
+  @ReactProp(name = ViewProps.ERROR_MESSAGE)
+  public void setAndroidErrorMessage(ReactEditText view, String error) {
     if (error != null) {
       view.setError(error);
     }