Skip to content

Commit

Permalink
Fix react-native-xcode.sh build script
Browse files Browse the repository at this point in the history
Summary:
This diff fixes USE_HERMES checks.

Changelog
[iOS][Fixed] - USE_HERMES envvar check fixed in react-native-xcode.sh.

Reviewed By: cipolleschi

Differential Revision: D38704558

fbshipit-source-id: 90a8648fd1094fcf9ab085f37efce9b811e707bc
  • Loading branch information
Dmitry Rykun authored and facebook-github-bot committed Aug 19, 2022
1 parent 0c2fe96 commit 61106ac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/react-native-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ fi

PACKAGER_SOURCEMAP_FILE=
if [[ $EMIT_SOURCEMAP == true ]]; then
if [[ $USE_HERMES == true ]]; then
if [[ $USE_HERMES != false ]]; then
PACKAGER_SOURCEMAP_FILE="$CONFIGURATION_BUILD_DIR/$(basename $SOURCEMAP_FILE)"
else
PACKAGER_SOURCEMAP_FILE="$SOURCEMAP_FILE"
Expand All @@ -138,7 +138,7 @@ if [[ $EMIT_SOURCEMAP == true ]]; then
fi

# Hermes doesn't require JS minification.
if [[ $USE_HERMES == true && $DEV == false ]]; then
if [[ $USE_HERMES != false && $DEV == false ]]; then
EXTRA_ARGS="$EXTRA_ARGS --minify false"
fi

Expand Down

0 comments on commit 61106ac

Please sign in to comment.