Upgrade Prettier in Xplat to version 1.19.1

Summary: Upgrades Prettier in Xplat to 1.19.1 Ignores upgrading packages on already on versions greater than 1.19.1 Changelog: [Internal] allow-large-files bypass-lint (Note: this ignores all push blocking failures!) Reviewed By: gkz, cpojer Differential Revision: D20879147 fbshipit-source-id: 0deee7ac941e91e1c3c3a1e7d3d3ed20de1d657d
facebook · Apr 9, 2020 · cd347a7 · cd347a7
1 parent cd13c99
commit cd347a7
Show file tree

Hide file tree

Showing 35 changed files with 150 additions and 171 deletions.
diff --git a/IntegrationTests/AsyncStorageTest.js b/IntegrationTests/AsyncStorageTest.js
@@ -152,7 +152,10 @@ function testMerge() {
 }
 
 function testOptimizedMultiGet() {
-  let batch = [[KEY_1, VAL_1], [KEY_2, VAL_2]];
+  let batch = [
+    [KEY_1, VAL_1],
+    [KEY_2, VAL_2],
+  ];
   let keys = batch.map(([key, value]) => key);
   AsyncStorage.multiSet(batch, err1 => {
     // yes, twice on purpose

diff --git a/Libraries/Animated/src/NativeAnimatedHelper.js b/Libraries/Animated/src/NativeAnimatedHelper.js
@@ -235,9 +235,7 @@ function validateTransform(
   configs.forEach(config => {
     if (!TRANSFORM_WHITELIST.hasOwnProperty(config.property)) {
       throw new Error(
-        `Property '${
-          config.property
-        }' is not supported by native animated module`,
+        `Property '${config.property}' is not supported by native animated module`,
       );
     }
   });

diff --git a/Libraries/Animated/src/__tests__/AnimatedNative-test.js b/Libraries/Animated/src/__tests__/AnimatedNative-test.js
@@ -357,11 +357,19 @@ describe('Native Animated', () => {
       expect(additionConnectionCalls.length).toBe(2);
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         additionCall[1].input[0],
-        {type: 'value', value: 1, offset: 0},
+        {
+          type: 'value',
+          value: 1,
+          offset: 0,
+        },
       );
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         additionCall[1].input[1],
-        {type: 'value', value: 2, offset: 0},
+        {
+          type: 'value',
+          value: 2,
+          offset: 0,
+        },
       );
     });
 
@@ -391,11 +399,19 @@ describe('Native Animated', () => {
       expect(subtractionConnectionCalls.length).toBe(2);
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         subtractionCall[1].input[0],
-        {type: 'value', value: 2, offset: 0},
+        {
+          type: 'value',
+          value: 2,
+          offset: 0,
+        },
       );
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         subtractionCall[1].input[1],
-        {type: 'value', value: 1, offset: 0},
+        {
+          type: 'value',
+          value: 1,
+          offset: 0,
+        },
       );
     });
 
@@ -425,11 +441,19 @@ describe('Native Animated', () => {
       expect(multiplicationConnectionCalls.length).toBe(2);
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         multiplicationCall[1].input[0],
-        {type: 'value', value: 2, offset: 0},
+        {
+          type: 'value',
+          value: 2,
+          offset: 0,
+        },
       );
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         multiplicationCall[1].input[1],
-        {type: 'value', value: 1, offset: 0},
+        {
+          type: 'value',
+          value: 1,
+          offset: 0,
+        },
       );
     });
 
@@ -459,11 +483,19 @@ describe('Native Animated', () => {
       expect(divisionConnectionCalls.length).toBe(2);
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         divisionCall[1].input[0],
-        {type: 'value', value: 4, offset: 0},
+        {
+          type: 'value',
+          value: 4,
+          offset: 0,
+        },
       );
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         divisionCall[1].input[1],
-        {type: 'value', value: 2, offset: 0},
+        {
+          type: 'value',
+          value: 2,
+          offset: 0,
+        },
       );
     });
 
@@ -491,7 +523,11 @@ describe('Native Animated', () => {
       expect(moduloConnectionCalls.length).toBe(1);
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         moduloCall[1].input,
-        {type: 'value', value: 4, offset: 0},
+        {
+          type: 'value',
+          value: 4,
+          offset: 0,
+        },
       );
     });
 
@@ -588,7 +624,11 @@ describe('Native Animated', () => {
       expect(diffClampConnectionCalls.length).toBe(1);
       expect(NativeAnimatedModule.createAnimatedNode).toBeCalledWith(
         diffClampCall[1].input,
-        {type: 'value', value: 2, offset: 0},
+        {
+          type: 'value',
+          value: 2,
+          offset: 0,
+        },
       );
     });
 

diff --git a/Libraries/BatchedBridge/__tests__/MessageQueue-test.js b/Libraries/BatchedBridge/__tests__/MessageQueue-test.js
@@ -81,13 +81,25 @@ describe('MessageQueue', function() {
   });
 
   it('should throw when calling the same callback twice', () => {
-    queue.enqueueNativeCall(0, 1, [], () => {}, () => {});
+    queue.enqueueNativeCall(
+      0,
+      1,
+      [],
+      () => {},
+      () => {},
+    );
     queue.__invokeCallback(1, []);
     expect(() => queue.__invokeCallback(1, [])).toThrow();
   });
 
   it('should throw when calling both success and failure callback', () => {
-    queue.enqueueNativeCall(0, 1, [], () => {}, () => {});
+    queue.enqueueNativeCall(
+      0,
+      1,
+      [],
+      () => {},
+      () => {},
+    );
     queue.__invokeCallback(1, []);
     expect(() => queue.__invokeCallback(0, [])).toThrow();
   });

diff --git a/Libraries/Blob/URL.js b/Libraries/Blob/URL.js
@@ -119,9 +119,7 @@ export class URL {
     if (BLOB_URL_PREFIX === null) {
       throw new Error('Cannot create URL for blob!');
     }
-    return `${BLOB_URL_PREFIX}${blob.data.blobId}?offset=${
-      blob.data.offset
-    }&size=${blob.size}`;
+    return `${BLOB_URL_PREFIX}${blob.data.blobId}?offset=${blob.data.offset}&size=${blob.size}`;
   }
 
   static revokeObjectURL(url: string) {

diff --git a/Libraries/Components/ActivityIndicator/ActivityIndicator.js b/Libraries/Components/ActivityIndicator/ActivityIndicator.js
@@ -101,10 +101,7 @@ const ActivityIndicator = (props: Props, forwardedRef?: any) => {
   return (
     <View
       onLayout={onLayout}
-      style={StyleSheet.compose(
-        styles.container,
-        style,
-      )}>
+      style={StyleSheet.compose(styles.container, style)}>
       {Platform.OS === 'android' ? (
         // $FlowFixMe Flow doesn't know when this is the android component
         <PlatformActivityIndicator {...nativeProps} {...androidProps} />

diff --git a/Libraries/Components/Keyboard/KeyboardAvoidingView.js b/Libraries/Components/Keyboard/KeyboardAvoidingView.js
@@ -170,10 +170,7 @@ class KeyboardAvoidingView extends React.Component<Props, State> {
         return (
           <View
             ref={this.viewRef}
-            style={StyleSheet.compose(
-              style,
-              heightStyle,
-            )}
+            style={StyleSheet.compose(style, heightStyle)}
             onLayout={this._onLayout}
             {...props}>
             {children}
@@ -188,12 +185,9 @@ class KeyboardAvoidingView extends React.Component<Props, State> {
             onLayout={this._onLayout}
             {...props}>
             <View
-              style={StyleSheet.compose(
-                contentContainerStyle,
-                {
-                  bottom: bottomHeight,
-                },
-              )}>
+              style={StyleSheet.compose(contentContainerStyle, {
+                bottom: bottomHeight,
+              })}>
               {children}
             </View>
           </View>
@@ -203,10 +197,7 @@ class KeyboardAvoidingView extends React.Component<Props, State> {
         return (
           <View
             ref={this.viewRef}
-            style={StyleSheet.compose(
-              style,
-              {paddingBottom: bottomHeight},
-            )}
+            style={StyleSheet.compose(style, {paddingBottom: bottomHeight})}
             onLayout={this._onLayout}
             {...props}>
             {children}

diff --git a/Libraries/Components/Picker/PickerAndroid.android.js b/Libraries/Components/Picker/PickerAndroid.android.js
@@ -121,10 +121,7 @@ function PickerAndroid(props: Props): React.Node {
     prompt: props.prompt,
     ref: pickerRef,
     selected,
-    style: StyleSheet.compose(
-      styles.pickerAndroid,
-      props.style,
-    ),
+    style: StyleSheet.compose(styles.pickerAndroid, props.style),
     backgroundColor: props.backgroundColor,
     testID: props.testID,
   };

diff --git a/Libraries/Components/Slider/Slider.js b/Libraries/Components/Slider/Slider.js
@@ -198,10 +198,7 @@ const Slider = (
   props: Props,
   forwardedRef?: ?React.Ref<typeof SliderNativeComponent>,
 ) => {
-  const style = StyleSheet.compose(
-    styles.slider,
-    props.style,
-  );
+  const style = StyleSheet.compose(styles.slider, props.style);
 
   const {
     disabled = false,

diff --git a/Libraries/Components/StatusBar/StatusBar.js b/Libraries/Components/StatusBar/StatusBar.js
@@ -467,9 +467,7 @@ class StatusBar extends React.Component<Props> {
         const processedColor = processColor(mergedProps.backgroundColor.value);
         if (processedColor == null) {
           console.warn(
-            `\`StatusBar._updatePropsStack\`: Color ${
-              mergedProps.backgroundColor.value
-            } parsed to null or undefined`,
+            `\`StatusBar._updatePropsStack\`: Color ${mergedProps.backgroundColor.value} parsed to null or undefined`,
           );
         } else {
           invariant(

diff --git a/Libraries/Interaction/TaskQueue.js b/Libraries/Interaction/TaskQueue.js
@@ -172,9 +172,7 @@ class TaskQueue {
         this.hasTasksToProcess() && this._onMoreTasks();
       })
       .catch(ex => {
-        ex.message = `TaskQueue: Error resolving Promise in task ${
-          task.name
-        }: ${ex.message}`;
+        ex.message = `TaskQueue: Error resolving Promise in task ${task.name}: ${ex.message}`;
         throw ex;
       })
       .done();

diff --git a/Libraries/Lists/FlatList.js b/Libraries/Lists/FlatList.js
@@ -593,11 +593,7 @@ class FlatList<ItemT> extends React.PureComponent<Props<ItemT>, void> {
             'Expected array of items with numColumns > 1',
           );
           return (
-            <View
-              style={StyleSheet.compose(
-                styles.row,
-                columnWrapperStyle,
-              )}>
+            <View style={StyleSheet.compose(styles.row, columnWrapperStyle)}>
               {item.map((it, kk) => {
                 const element = renderer({
                   item: it,

diff --git a/Libraries/Lists/VirtualizedList.js b/Libraries/Lists/VirtualizedList.js
@@ -1117,10 +1117,7 @@ class VirtualizedList extends React.PureComponent<Props, State> {
               element.props.onLayout(event);
             }
           },
-          style: StyleSheet.compose(
-            inversionStyle,
-            element.props.style,
-          ),
+          style: StyleSheet.compose(inversionStyle, element.props.style),
         }),
       );
     }

diff --git a/Libraries/Lists/__tests__/ViewabilityHelper-test.js b/Libraries/Lists/__tests__/ViewabilityHelper-test.js
@@ -429,7 +429,10 @@ describe('onUpdate', function() {
 
     expect(onViewableItemsChanged.mock.calls.length).toBe(2);
     expect(onViewableItemsChanged.mock.calls[1][0]).toEqual({
-      changed: [{isViewable: true, key: 'c'}, {isViewable: false, key: 'a'}],
+      changed: [
+        {isViewable: true, key: 'c'},
+        {isViewable: false, key: 'a'},
+      ],
       viewabilityConfig: {viewAreaCoveragePercentThreshold: 0},
       viewableItems: [{isViewable: true, key: 'c'}],
     });

diff --git a/Libraries/LogBox/Data/__tests__/LogBoxLog-test.js b/Libraries/LogBox/Data/__tests__/LogBoxLog-test.js
@@ -19,7 +19,7 @@ jest.mock('../LogBoxSymbolication', () => {
 });
 
 function getLogBoxLog() {
-  return new (require('../LogBoxLog')).default({
+  return new (require('../LogBoxLog').default)({
     level: 'warn',
     isComponentError: false,
     message: {content: '...', substitutions: []},

diff --git a/Libraries/Modal/Modal.js b/Libraries/Modal/Modal.js
@@ -190,9 +190,7 @@ class Modal extends React.Component<Props> {
       props.transparent
     ) {
       console.warn(
-        `Modal with '${
-          props.presentationStyle
-        }' presentation style and 'transparent' value is not supported.`,
+        `Modal with '${props.presentationStyle}' presentation style and 'transparent' value is not supported.`,
       );
     }
   }

diff --git a/Libraries/StyleSheet/__flowtests__/StyleSheet-flowtest.js b/Libraries/StyleSheet/__flowtests__/StyleSheet-flowtest.js
@@ -18,53 +18,29 @@ const textStyle = {color: 'rgb(0, 0, 0)'};
 
 module.exports = {
   testGoodCompose() {
-    (StyleSheet.compose(
-      imageStyle,
-      imageStyle,
-    ): ImageStyleProp);
+    (StyleSheet.compose(imageStyle, imageStyle): ImageStyleProp);
 
-    (StyleSheet.compose(
-      textStyle,
-      textStyle,
-    ): TextStyleProp);
+    (StyleSheet.compose(textStyle, textStyle): TextStyleProp);
 
-    (StyleSheet.compose(
-      null,
-      null,
-    ): TextStyleProp);
+    (StyleSheet.compose(null, null): TextStyleProp);
 
-    (StyleSheet.compose(
-      textStyle,
-      null,
-    ): TextStyleProp);
+    (StyleSheet.compose(textStyle, null): TextStyleProp);
 
     (StyleSheet.compose(
       textStyle,
       Math.random() < 0.5 ? textStyle : null,
     ): TextStyleProp);
 
-    (StyleSheet.compose(
-      [textStyle],
-      null,
-    ): TextStyleProp);
+    (StyleSheet.compose([textStyle], null): TextStyleProp);
 
-    (StyleSheet.compose(
-      [textStyle],
-      null,
-    ): TextStyleProp);
+    (StyleSheet.compose([textStyle], null): TextStyleProp);
 
-    (StyleSheet.compose(
-      [textStyle],
-      [textStyle],
-    ): TextStyleProp);
+    (StyleSheet.compose([textStyle], [textStyle]): TextStyleProp);
   },
 
   testBadCompose() {
     // $FlowExpectedError - Incompatible type.
-    (StyleSheet.compose(
-      textStyle,
-      textStyle,
-    ): ImageStyleProp);
+    (StyleSheet.compose(textStyle, textStyle): ImageStyleProp);
 
     // $FlowExpectedError - Incompatible type.
     (StyleSheet.compose(